Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Added correct include for GET /teams/{teamId}/event-types #12459

Merged
merged 7 commits into from
Nov 27, 2023

Conversation

kaulshashank
Copy link
Contributor

What does this PR do?

API for GET /teams/{teamId}/event-types does not include hosts and other fields that GET /event-types does.

Fixes # (issue)

#12402

Requirement/Documentation

N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Are there environment variables that should be set?

  • What are the minimal test data to have?

A team event type with 1 or more hosts (either fixed and/or RR will do)

  • What is expected (happy path) to have (input and output)?

API request to GET /v1/teams/1/event-types should have a correctly populated hosts array.

  • Any other important info that could help to test that PR

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

Copy link

vercel bot commented Nov 21, 2023

@kaulshashank is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Nov 21, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

Copy link
Contributor

github-actions bot commented Nov 21, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@PeerRich PeerRich added Medium priority Created by Linear-GitHub Sync api area: API, enterprise API, access token, OAuth labels Nov 22, 2023
@CarinaWolli CarinaWolli requested a review from a team November 22, 2023 17:56
@kaulshashank
Copy link
Contributor Author

Hey @CarinaWolli, can I get this approved sooner? Ali already gave the go on the code change to be done over here: #12402 (comment) and I've tested this locally once as well.

Copy link
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It's the same now as in /api/event-types/_get

@CarinaWolli CarinaWolli enabled auto-merge (squash) November 27, 2023 16:00
@CarinaWolli CarinaWolli merged commit b26e688 into calcom:main Nov 27, 2023
27 of 34 checks passed
@kaulshashank kaulshashank deleted the fix/team-event-types-list-hosts branch November 27, 2023 16:44
jakazzy pushed a commit to jakazzy/cal.com that referenced this pull request Dec 5, 2023
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants