-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve logs #12467
chore: improve logs #12467
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 338 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 11/27/2023 12:46:13pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 30e3b71 Started: 11/27/2023 12:40:21pm UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Booking with Seats Multiple Attendees can book a seated event time slot
Retry 1 • Initial Attempt |
0% (0)0 / 258 runsfailed over last 7 days |
0.78% (2)2 / 258 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 4 Flakes
Top 1 Common Error Messages
|
4 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt |
10.68% (30)30 / 281 runsfailed over last 7 days |
85.41% (240)240 / 281 runsflaked over last 7 days |
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
2.13% (6)6 / 282 runsfailed over last 7 days |
29.43% (83)83 / 282 runsflaked over last 7 days |
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
1.06% (3)3 / 283 runsfailed over last 7 days |
68.20% (193)193 / 283 runsflaked over last 7 days |
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
0.36% (1)1 / 281 runfailed over last 7 days |
54.80% (154)154 / 281 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-creation.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Organization should be able to create an organization and complete onboarding
Retry 2 • Retry 1 • Initial Attempt |
2.13% (4)4 / 188 runsfailed over last 7 days |
96.28% (181)181 / 188 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1 • Initial Attempt |
0% (0)0 / 268 runsfailed over last 7 days |
6.34% (17)17 / 268 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Organization Invitation (non verified)
Retry 1 • Initial Attempt |
5.88% (11)11 / 187 runsfailed over last 7 days |
17.11% (32)32 / 187 runsflaked over last 7 days |
📄 apps/web/playwright/settings/upload-avatar.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
UploadAvatar can upload an image
Retry 1 • Initial Attempt |
0% (0)0 / 259 runsfailed over last 7 days |
7.72% (20)20 / 259 runsflaked over last 7 days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good refactor
@@ -106,6 +107,7 @@ export default class GoogleCalendarService implements Calendar { | |||
}); | |||
myGoogleAuth.setCredentials(googleCredentials); | |||
} catch (err) { | |||
this.log.error("Error Refreshing Google Token", safeStringify(err)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this log to check why we are unable to refresh token for some users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lot's of tests are failing, @Udit-takkar
Getting this Error: Docker pull failed with exit code 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - will be superhelpful debugging
lets just get this one nit changed then i we can merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good !
not related to the code changes
* chore: improve logs * fix: import * chore: use safe stringify * chore: add more logs to google calendar * chore: use this.log --------- Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com>
* chore: improve logs * fix: import * chore: use safe stringify * chore: add more logs to google calendar * chore: use this.log --------- Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com>
#12460 (comment)