Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve logs #12467

Merged
merged 10 commits into from
Nov 29, 2023
Merged

chore: improve logs #12467

merged 10 commits into from
Nov 29, 2023

Conversation

Udit-takkar
Copy link
Contributor

  • Improve some logs and replaced stringify with safeStringify

#12460 (comment)

Copy link

vercel bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 0:42am
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 0:42am
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2023 0:42am
cal ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2023 0:42am
cal-demo ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2023 0:42am
qa ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2023 0:42am
ui ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2023 0:42am

Copy link
Contributor

github-actions bot commented Nov 21, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

Copy link
Contributor

github-actions bot commented Nov 21, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Nov 21, 2023

Current Playwright Test Results Summary

✅ 338 Passing - ⚠️ 9 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 11/27/2023 12:46:13pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 30e3b71

Started: 11/27/2023 12:40:21pm UTC

⚠️ Flakes

📄   apps/web/playwright/booking-seats.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking with Seats Multiple Attendees can book a seated event time slot
Retry 1Initial Attempt
0% (0) 0 / 258 runs
failed over last 7 days
0.78% (2) 2 / 258 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 4 Flakes

Top 1 Common Error Messages

null

4 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 2Retry 1Initial Attempt
10.68% (30) 30 / 281 runs
failed over last 7 days
85.41% (240) 240 / 281 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
2.13% (6) 6 / 282 runs
failed over last 7 days
29.43% (83) 83 / 282 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
1.06% (3) 3 / 283 runs
failed over last 7 days
68.20% (193) 193 / 283 runs
flaked over last 7 days
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
0.36% (1) 1 / 281 run
failed over last 7 days
54.80% (154) 154 / 281 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-creation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization should be able to create an organization and complete onboarding
Retry 2Retry 1Initial Attempt
2.13% (4) 4 / 188 runs
failed over last 7 days
96.28% (181) 181 / 188 runs
flaked over last 7 days

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1Initial Attempt
0% (0) 0 / 268 runs
failed over last 7 days
6.34% (17) 17 / 268 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization Invitation (non verified)
Retry 1Initial Attempt
5.88% (11) 11 / 187 runs
failed over last 7 days
17.11% (32) 32 / 187 runs
flaked over last 7 days

📄   apps/web/playwright/settings/upload-avatar.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
UploadAvatar can upload an image
Retry 1Initial Attempt
0% (0) 0 / 259 runs
failed over last 7 days
7.72% (20) 20 / 259 runs
flaked over last 7 days

View Detailed Build Results


PeerRich
PeerRich previously approved these changes Nov 22, 2023
Copy link
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good refactor

@PeerRich PeerRich added the Medium priority Created by Linear-GitHub Sync label Nov 22, 2023
@Udit-takkar Udit-takkar marked this pull request as draft November 22, 2023 12:05
@@ -106,6 +107,7 @@ export default class GoogleCalendarService implements Calendar {
});
myGoogleAuth.setCredentials(googleCredentials);
} catch (err) {
this.log.error("Error Refreshing Google Token", safeStringify(err));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this log to check why we are unable to refresh token for some users.

Copy link
Contributor

@keithwillcode keithwillcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lot's of tests are failing, @Udit-takkar

@Udit-takkar
Copy link
Contributor Author

Lot's of tests are failing, @Udit-takkar

Getting this Error: Docker pull failed with exit code 1

Copy link
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - will be superhelpful debugging

lets just get this one nit changed then i we can merge

packages/app-store/googlecalendar/lib/CalendarService.ts Outdated Show resolved Hide resolved
Copy link
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ThyMinimalDev ThyMinimalDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good !

@Udit-takkar Udit-takkar dismissed keithwillcode’s stale review November 29, 2023 14:09

not related to the code changes

@sean-brydon sean-brydon merged commit 7dc6df2 into main Nov 29, 2023
37 checks passed
@sean-brydon sean-brydon deleted the fix/improve-logging branch November 29, 2023 14:09
jakazzy pushed a commit to jakazzy/cal.com that referenced this pull request Dec 5, 2023
* chore: improve logs

* fix: import

* chore: use safe stringify

* chore: add more logs to google calendar

* chore: use this.log

---------

Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com>
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Dec 21, 2023
* chore: improve logs

* fix: import

* chore: use safe stringify

* chore: add more logs to google calendar

* chore: use this.log

---------

Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants