fix: improved team upgrade screen to also show unpublished teams #12492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAL-2743 show unpublished teams
right now, if you have an unpublished team, it still shows the empty screen |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
github-actions
bot
added
Low priority
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
PeerRich
commented
Nov 22, 2023
PeerRich
commented
Nov 22, 2023
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 347 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 11/29/2023 09:43:46pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 49720da Started: 11/29/2023 09:36:47pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Select Question and checkbox group Question Select required and checkbox group required
Retry 1 • Initial Attempt |
0.33% (1)1 / 306 runfailed over last 7 days |
2.61% (8)8 / 306 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user -- future Different Locations Tests can select 'display on booking page' option when multiple organizer input type are present
Retry 1 • Initial Attempt |
0% (0)0 / 268 runsfailed over last 7 days |
4.48% (12)12 / 268 runsflaked over last 7 days |
|
Event Types tests user -- legacy Different Locations Tests can add single organizer address location without display location public option
Retry 1 • Initial Attempt |
0% (0)0 / 268 runsfailed over last 7 days |
0.75% (2)2 / 268 runsflaked over last 7 days |
📄 apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Address Question and Each Other Question Booking With Address Question and Multi email Question Address and Multi email not required
Retry 1 • Initial Attempt |
0% (0)0 / 315 runsfailed over last 7 days |
0.63% (2)2 / 315 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Organization Invitation (non verified)
Retry 1 • Initial Attempt |
9.78% (31)31 / 317 runsfailed over last 7 days |
21.77% (69)69 / 317 runsflaked over last 7 days |
📄 apps/web/playwright/team/team-invitation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Team Invitation (non verified)
Retry 1 • Initial Attempt |
2.36% (7)7 / 297 runsfailed over last 7 days |
17.85% (53)53 / 297 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
6.29% (21)21 / 334 runsfailed over last 7 days |
90.42% (302)302 / 334 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
0.89% (3)3 / 336 runsfailed over last 7 days |
74.70% (251)251 / 336 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-creation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Organization should be able to create an organization and complete onboarding
Retry 1 • Initial Attempt |
2.52% (8)8 / 318 runsfailed over last 7 days |
94.65% (301)301 / 318 runsflaked over last 7 days |
📄 apps/web/playwright/booking/multipleEmailQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and Address Question Multiple Email required and Address required
Retry 1 • Initial Attempt |
2.47% (8)8 / 324 runsfailed over last 7 days |
1.23% (4)4 / 324 runsflaked over last 7 days |
PeerRich
added
Medium priority
zomars
reviewed
Nov 29, 2023
zomars
reviewed
Nov 29, 2023
zomars
previously approved these changes
Nov 29, 2023
zomars
approved these changes
Nov 29, 2023
jakazzy
pushed a commit
to jakazzy/cal.com
that referenced
this pull request
Dec 5, 2023
…com#12492) * improved team upgrade screen to also show unpublished teams * Update TeamsListing.tsx * bunch of stuff --------- Co-authored-by: Omar López <zomars@me.com>
hbjORbj
pushed a commit
to codemod-com/cal.com-demo
that referenced
this pull request
Dec 21, 2023
…com#12492) * improved team upgrade screen to also show unpublished teams * Update TeamsListing.tsx * bunch of stuff --------- Co-authored-by: Omar López <zomars@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo:
before:
after:
