Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove cache-control and disable avatar cache #12517

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

emrysal
Copy link
Contributor

@emrysal emrysal commented Nov 23, 2023

What does this PR do?

This URL cannot be invalidated, so causes 1-day out of date avatars (or whenever the browser decides not to cache)

@emrysal emrysal requested a review from zomars November 23, 2023 23:15
Copy link

vercel bot commented Nov 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2023 11:39pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2023 11:39pm
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2023 11:39pm
cal ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2023 11:39pm
cal-demo ⬜️ Ignored (Inspect) Nov 23, 2023 11:39pm
qa ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2023 11:39pm
ui ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2023 11:39pm

Copy link
Contributor

github-actions bot commented Nov 23, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

Copy link
Contributor

github-actions bot commented Nov 23, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@emrysal emrysal changed the title Remove cache-control and disable cache chore: Remove cache-control and disable cache Nov 23, 2023
@emrysal emrysal changed the title chore: Remove cache-control and disable cache chore: Remove cache-control and disable avatar cache Nov 23, 2023
Copy link

deploysentinel bot commented Nov 23, 2023

Current Playwright Test Results Summary

✅ 327 Passing - ⚠️ 21 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 11/23/2023 11:40:44pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 145f858

Started: 11/23/2023 11:33:33pm UTC

⚠️ Flakes

📄   apps/web/playwright/locale.e2e.ts • 13 Flakes

Top 1 Common Error Messages

null

13 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
unauthorized user sees correct translations (de) should use correct translations and html attributes
Retry 1Initial Attempt
-20.21% (-59) -59 / 292 runs
failed over last 7 days
20.21% (59) 59 / 292 runs
flaked over last 7 days
unauthorized user sees correct translations (ar) should use correct translations and html attributes
Retry 1Initial Attempt
-20.21% (-59) -59 / 292 runs
failed over last 7 days
20.21% (59) 59 / 292 runs
flaked over last 7 days
unauthorized user sees correct translations (zh) should use correct translations and html attributes
Retry 1Initial Attempt
-20.21% (-59) -59 / 292 runs
failed over last 7 days
20.21% (59) 59 / 292 runs
flaked over last 7 days
unauthorized user sees correct translations (zh-CN) should use correct translations and html attributes
Retry 1Initial Attempt
-20.21% (-59) -59 / 292 runs
failed over last 7 days
20.21% (59) 59 / 292 runs
flaked over last 7 days
unauthorized user sees correct translations (zh-TW) should use correct translations and html attributes
Retry 1Initial Attempt
-20.21% (-59) -59 / 292 runs
failed over last 7 days
20.21% (59) 59 / 292 runs
flaked over last 7 days
unauthorized user sees correct translations (pt) should use correct translations and html attributes
Retry 1Initial Attempt
-20.21% (-59) -59 / 292 runs
failed over last 7 days
20.21% (59) 59 / 292 runs
flaked over last 7 days
unauthorized user sees correct translations (pt-br) should use correct translations and html attributes
Retry 1Initial Attempt
-19.86% (-58) -58 / 292 runs
failed over last 7 days
20.21% (59) 59 / 292 runs
flaked over last 7 days
unauthorized user sees correct translations (es-419) should use correct translations and html attributes
Retry 1Initial Attempt
-20.21% (-59) -59 / 292 runs
failed over last 7 days
20.21% (59) 59 / 292 runs
flaked over last 7 days
authorized user sees correct translations (de) should return correct translations and html attributes
Retry 1Initial Attempt
-17.93% (-52) -52 / 290 runs
failed over last 7 days
20.34% (59) 59 / 290 runs
flaked over last 7 days
authorized user sees correct translations (pt-br) should return correct translations and html attributes
Retry 1Initial Attempt
-19.08% (-54) -54 / 283 runs
failed over last 7 days
20.85% (59) 59 / 283 runs
flaked over last 7 days
authorized user sees correct translations (ar) should return correct translations and html attributes
Retry 1Initial Attempt
-20.50% (-57) -57 / 278 runs
failed over last 7 days
20.86% (58) 58 / 278 runs
flaked over last 7 days
authorized user sees changed translations (de->ar) should return correct translations and html attributes
Retry 1Initial Attempt
-9.42% (-26) -26 / 276 runs
failed over last 7 days
16.67% (46) 46 / 276 runs
flaked over last 7 days
authorized user sees changed translations (de->pt-BR) [locale1] should return correct translations and html attributes
Retry 1Initial Attempt
-10.55% (-27) -27 / 256 runs
failed over last 7 days
16.41% (42) 42 / 256 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 4 Flakes

Top 1 Common Error Messages

null

4 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
1.91% (6) 6 / 314 runs
failed over last 7 days
52.23% (164) 164 / 314 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
1.90% (6) 6 / 315 runs
failed over last 7 days
26.98% (85) 85 / 315 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 2Retry 1Initial Attempt
15.61% (49) 49 / 314 runs
failed over last 7 days
80.25% (252) 252 / 314 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
2.85% (9) 9 / 316 runs
failed over last 7 days
62.34% (197) 197 / 316 runs
flaked over last 7 days

📄   apps/web/playwright/teams.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams - NonOrg Can create a private team
Retry 1Initial Attempt
0% (0) 0 / 304 runs
failed over last 7 days
24.01% (73) 73 / 304 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-creation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization should be able to create an organization and complete onboarding
Retry 2Retry 1Initial Attempt
1.69% (2) 2 / 118 runs
failed over last 7 days
96.61% (114) 114 / 118 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests user -- future Different Locations Tests can add Attendee Phone Number location and book with it
Retry 1Initial Attempt
0% (0) 0 / 58 runs
failed over last 7 days
13.79% (8) 8 / 58 runs
flaked over last 7 days

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link should validate fields
Retry 1Initial Attempt
0.68% (2) 2 / 295 runs
failed over last 7 days
12.54% (37) 37 / 295 runs
flaked over last 7 days

View Detailed Build Results


@emrysal emrysal enabled auto-merge (squash) November 23, 2023 23:34
@emrysal emrysal merged commit 0ddefaa into main Nov 23, 2023
36 checks passed
@emrysal emrysal deleted the bugfix/disable-avatar-cache branch November 23, 2023 23:42
jakazzy pushed a commit to jakazzy/cal.com that referenced this pull request Dec 5, 2023
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants