fix: OAuth URL account for dev environment #12530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
joeauyeung
commented
Nov 24, 2023
| @@ -17,7 +18,7 @@ export const WEBAPP_URL = | |||
|
|
|||
| // OAuth needs to have HTTPS(which is not generally setup locally) and a valid tld(*.local isn't a valid tld) | |||
| // So for development purpose, we would stick to localhost only | |||
| export const WEBAPP_URL_FOR_OAUTH = IS_PRODUCTION ? WEBAPP_URL : "http://localhost:3000"; | |||
| export const WEBAPP_URL_FOR_OAUTH = IS_PRODUCTION || IS_DEV ? WEBAPP_URL : "http://localhost:3000"; | |||
There was a problem hiding this comment.
Confirmed in a replit that this will return true if either IS_PRODUCTION or IS_DEV is true.
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 338 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 11/24/2023 05:36:49pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 37b5793 Started: 11/24/2023 05:29:49pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1 • Initial Attempt |
0.37% (1)1 / 267 runfailed over last 7 days |
27.34% (73)73 / 267 runsflaked over last 7 days |
📄 apps/web/playwright/teams.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams - NonOrg Can create a private team
Retry 1 • Initial Attempt |
0% (0)0 / 280 runsfailed over last 7 days |
23.21% (65)65 / 280 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 4 Flakes
Top 1 Common Error Messages
|
|
4 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
1.75% (5)5 / 286 runsfailed over last 7 days |
52.45% (150)150 / 286 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt |
12.94% (37)37 / 286 runsfailed over last 7 days |
83.22% (238)238 / 286 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
2.78% (8)8 / 288 runsfailed over last 7 days |
63.19% (182)182 / 288 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
1.74% (5)5 / 287 runsfailed over last 7 days |
26.83% (77)77 / 287 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-creation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Organization should be able to create an organization and complete onboarding
Retry 2 • Retry 1 • Initial Attempt |
2.84% (4)4 / 141 runsfailed over last 7 days |
95.04% (134)134 / 141 runsflaked over last 7 days |
📄 apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Address Question and Each Other Question Booking With Address Question and Long text Question Addres required and Long Text required
Retry 1 • Initial Attempt |
0% (0)0 / 263 runsfailed over last 7 days |
0.38% (1)1 / 263 runflaked over last 7 days |
hariombalhara
approved these changes
Nov 24, 2023
jakazzy
pushed a commit
to jakazzy/cal.com
that referenced
this pull request
Dec 5, 2023
hbjORbj
pushed a commit
to codemod-com/cal.com-demo
that referenced
this pull request
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR allows the
WEBAPP_URL_FOR_OAUTHto account for our dev environment to use theWEBPP_URLinstead of defaulting back to localhost.Fixes # (issue)
Requirement/Documentation
Type of change
How should this be tested?
Mandatory Tasks
Checklist