refactor: Top Banner and add google calendar credential banner #12532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Seventy Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 335 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 12/07/2023 07:46:56am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: b4f4d1d Started: 12/07/2023 07:40:33am UTC
|
|
|
13 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
unauthorized user sees correct translations (de) should use correct translations and html attributes
Retry 2 • Retry 1 • Initial Attempt |
-80.45% (-177)-177 / 220 runsfailed over last 7 days |
81.82% (180)180 / 220 runsflaked over last 7 days |
|
unauthorized user sees correct translations (ar) should use correct translations and html attributes
Retry 2 • Retry 1 • Initial Attempt |
-82.49% (-179)-179 / 217 runsfailed over last 7 days |
82.95% (180)180 / 217 runsflaked over last 7 days |
|
unauthorized user sees correct translations (zh) should use correct translations and html attributes
Retry 2 • Retry 1 • Initial Attempt |
-83.33% (-180)-180 / 216 runsfailed over last 7 days |
83.33% (180)180 / 216 runsflaked over last 7 days |
|
unauthorized user sees correct translations (zh-CN) should use correct translations and html attributes
Retry 2 • Retry 1 • Initial Attempt |
-83.33% (-180)-180 / 216 runsfailed over last 7 days |
83.33% (180)180 / 216 runsflaked over last 7 days |
|
unauthorized user sees correct translations (zh-TW) should use correct translations and html attributes
Retry 2 • Retry 1 • Initial Attempt |
-82.87% (-179)-179 / 216 runsfailed over last 7 days |
83.33% (180)180 / 216 runsflaked over last 7 days |
|
unauthorized user sees correct translations (pt) should use correct translations and html attributes
Retry 2 • Retry 1 • Initial Attempt |
-83.72% (-180)-180 / 215 runsfailed over last 7 days |
83.72% (180)180 / 215 runsflaked over last 7 days |
|
unauthorized user sees correct translations (pt-br) should use correct translations and html attributes
Retry 2 • Retry 1 • Initial Attempt |
-83.26% (-179)-179 / 215 runsfailed over last 7 days |
83.72% (180)180 / 215 runsflaked over last 7 days |
|
unauthorized user sees correct translations (es-419) should use correct translations and html attributes
Retry 2 • Retry 1 • Initial Attempt |
-84.11% (-180)-180 / 214 runsfailed over last 7 days |
84.11% (180)180 / 214 runsflaked over last 7 days |
|
authorized user sees correct translations (de) should return correct translations and html attributes
Retry 2 • Retry 1 • Initial Attempt |
-83.18% (-178)-178 / 214 runsfailed over last 7 days |
84.11% (180)180 / 214 runsflaked over last 7 days |
|
authorized user sees correct translations (pt-br) should return correct translations and html attributes
Retry 2 • Retry 1 • Initial Attempt |
-84.91% (-180)-180 / 212 runsfailed over last 7 days |
84.91% (180)180 / 212 runsflaked over last 7 days |
|
authorized user sees correct translations (ar) should return correct translations and html attributes
Retry 2 • Retry 1 • Initial Attempt |
-84.43% (-179)-179 / 212 runsfailed over last 7 days |
84.91% (180)180 / 212 runsflaked over last 7 days |
|
authorized user sees changed translations (de->ar) should return correct translations and html attributes
Retry 2 • Retry 1 • Initial Attempt |
-22.27% (-47)-47 / 211 runsfailed over last 7 days |
54.98% (116)116 / 211 runsflaked over last 7 days |
|
authorized user sees changed translations (de->pt-BR) [locale1] should return correct translations and html attributes
Retry 2 • Retry 1 • Initial Attempt |
-29.08% (-41)-41 / 141 runsfailed over last 7 days |
58.16% (82)82 / 141 runsflaked over last 7 days |
📄 apps/web/playwright/login.2fa.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 2 • Retry 1 • Initial Attempt |
1.80% (4)4 / 222 runsfailed over last 7 days |
27.03% (60)60 / 222 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user -- legacy Different Locations Tests can add Attendee Phone Number location and book with it
Retry 1 • Initial Attempt |
0% (0)0 / 215 runsfailed over last 7 days |
2.33% (5)5 / 215 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 4 Flakes
Top 1 Common Error Messages
|
|
4 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
3.85% (9)9 / 234 runsfailed over last 7 days |
58.55% (137)137 / 234 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
1.29% (3)3 / 233 runsfailed over last 7 days |
45.06% (105)105 / 233 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt |
6.84% (16)16 / 234 runsfailed over last 7 days |
87.18% (204)204 / 234 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
3.85% (9)9 / 234 runsfailed over last 7 days |
76.92% (180)180 / 234 runsflaked over last 7 days |
📄 apps/web/playwright/oauth-provider.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
OAuth Provider should create valid access toke & refresh token for team
Retry 1 • Initial Attempt |
1.24% (3)3 / 241 runsfailed over last 7 days |
21.16% (51)51 / 241 runsflaked over last 7 days |
Udit-takkar
changed the title
packages/trpc/server/routers/loggedInViewer/getUserTopBanners.handler.ts
Outdated
Show resolved
Hide resolved
packages/trpc/server/routers/viewer/organizations/checkIfOrgNeedsUpgrade.handler.ts
Outdated
Show resolved
Hide resolved
packages/trpc/server/routers/viewer/teams/getUpgradeable.handler.ts
Outdated
Show resolved
Hide resolved
|
Type check is failing, can you take a look @Udit-takkar |
zomars
requested changes
Dec 6, 2023
zomars
reviewed
Dec 6, 2023
zomars
approved these changes
Dec 7, 2023
hbjORbj
pushed a commit
to codemod-com/cal.com-demo
that referenced
this pull request
Dec 21, 2023
…m#12532) Fixes: calcom#12473 TODO: - [x] Fix Type error <img width="1512" alt="Screenshot 2023-12-02 at 12 47 19 AM" src="https://github.com/calcom/cal.com/assets/53316345/8a5c6dd0-6095-482b-b4d0-81653607a270"> <img width="1512" alt="Screenshot 2023-12-02 at 12 47 39 AM" src="https://github.com/calcom/cal.com/assets/53316345/fc64edb9-27b3-438f-b42d-75b200ac96e9">
haranrk
pushed a commit
to haranrk/cal.com
that referenced
this pull request
Jan 4, 2024
…m#12532) Fixes: calcom#12473 TODO: - [x] Fix Type error <img width="1512" alt="Screenshot 2023-12-02 at 12 47 19 AM" src="https://github.com/calcom/cal.com/assets/53316345/8a5c6dd0-6095-482b-b4d0-81653607a270"> <img width="1512" alt="Screenshot 2023-12-02 at 12 47 39 AM" src="https://github.com/calcom/cal.com/assets/53316345/fc64edb9-27b3-438f-b42d-75b200ac96e9">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12473
TODO: