Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: small UI improvements for troubleshooter #12535

Merged
merged 13 commits into from
Nov 27, 2023

Conversation

PeerRich
Copy link
Member

@PeerRich PeerRich commented Nov 24, 2023

after:

CleanShot 2023-11-24 at 23 03 14@2x

CleanShot 2023-11-24 at 23 02 45@2x

how to test

  • visit your own link on localhost

  • see "need help" button

  • click it

  • visit someone else's link on local host

  • don't see the "need help" button

@PeerRich PeerRich linked an issue Nov 24, 2023 that may be closed by this pull request
Copy link

linear bot commented Nov 24, 2023

CAL-2756 show troubleshooter on your own page

when visiting your own profile page, it should show a button to open troubleshooter

Copy link

vercel bot commented Nov 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 3:58pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 3:58pm
qa 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 3:58pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2023 3:58pm
cal ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2023 3:58pm
cal-demo ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2023 3:58pm
ui ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2023 3:58pm

Copy link
Contributor

github-actions bot commented Nov 24, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@github-actions github-actions bot added ui area: UI, frontend, button, form, input ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ✨ feature New feature or request ❗️ .env changes contains changes to env variables labels Nov 24, 2023
@zomars zomars added the core area: core, team members only label Nov 24, 2023
@PeerRich PeerRich removed the ❗️ .env changes contains changes to env variables label Nov 24, 2023
Copy link
Contributor

github-actions bot commented Nov 24, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Nov 24, 2023

Current Playwright Test Results Summary

✅ 338 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 11/27/2023 04:04:59pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: e6ac4b6

Started: 11/27/2023 03:55:15pm UTC

⚠️ Flakes

📄   apps/web/playwright/organization/organization-creation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization should be able to create an organization and complete onboarding
Retry 2Retry 1Initial Attempt
2.08% (4) 4 / 192 runs
failed over last 7 days
96.35% (185) 185 / 192 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests user -- future Different Locations Tests Can add Link Meeting as location and book with it
Retry 1Initial Attempt
0% (0) 0 / 128 runs
failed over last 7 days
6.25% (8) 8 / 128 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
10.84% (31) 31 / 286 runs
failed over last 7 days
85.31% (244) 244 / 286 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
1.39% (4) 4 / 288 runs
failed over last 7 days
68.06% (196) 196 / 288 runs
flaked over last 7 days

View Detailed Build Results


<Button
color="primary"
target="_blank"
href={`${WEBAPP_URL}/availability/troubleshoot?eventType=${eventSlug}`}>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works, but for some reason the URL does not take the state and by default loads the first event-type in the dropdown

cc @sean-brydon

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting may have been a bug on the router part - taking a look. Will just push changes to this branch

@@ -54,12 +62,23 @@ export function Header({
<LayoutToggle onLayoutToggle={onLayoutToggle} layout={layout} enabledLayouts={enabledLayouts} />
);
};
const isMyLink = username === session?.data?.user.username; // TODO: check for if the user is the owner of the link
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only show this button if your logged in session === the link of the username

Copy link
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) Thanks for fixes

@PeerRich PeerRich enabled auto-merge (squash) November 27, 2023 15:49
@PeerRich PeerRich merged commit f60b3c1 into main Nov 27, 2023
34 checks passed
@PeerRich PeerRich deleted the 12533-cal-2756-show-troubleshooter-on-your-own-page branch November 27, 2023 16:06
jakazzy pushed a commit to jakazzy/cal.com that referenced this pull request Dec 5, 2023
Co-authored-by: Sean Brydon <sean@brydon.io>
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Dec 21, 2023
Co-authored-by: Sean Brydon <sean@brydon.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only ✨ feature New feature or request ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-2756] show troubleshooter on your own page
3 participants