-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: small UI improvements for troubleshooter #12535
fix: small UI improvements for troubleshooter #12535
Conversation
CAL-2756 show troubleshooter on your own page
when visiting your own profile page, it should show a button to open troubleshooter |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 338 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 11/27/2023 04:04:59pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: e6ac4b6 Started: 11/27/2023 03:55:15pm UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Organization should be able to create an organization and complete onboarding
Retry 2 • Retry 1 • Initial Attempt |
2.08% (4)4 / 192 runsfailed over last 7 days |
96.35% (185)185 / 192 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Event Types tests user -- future Different Locations Tests Can add Link Meeting as location and book with it
Retry 1 • Initial Attempt |
0% (0)0 / 128 runsfailed over last 7 days |
6.25% (8)8 / 128 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
2 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
10.84% (31)31 / 286 runsfailed over last 7 days |
85.31% (244)244 / 286 runsflaked over last 7 days |
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
1.39% (4)4 / 288 runsfailed over last 7 days |
68.06% (196)196 / 288 runsflaked over last 7 days |
<Button | ||
color="primary" | ||
target="_blank" | ||
href={`${WEBAPP_URL}/availability/troubleshoot?eventType=${eventSlug}`}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this works, but for some reason the URL does not take the state and by default loads the first event-type in the dropdown
cc @sean-brydon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting may have been a bug on the router part - taking a look. Will just push changes to this branch
@@ -54,12 +62,23 @@ export function Header({ | |||
<LayoutToggle onLayoutToggle={onLayoutToggle} layout={layout} enabledLayouts={enabledLayouts} /> | |||
); | |||
}; | |||
const isMyLink = username === session?.data?.user.username; // TODO: check for if the user is the owner of the link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only show this button if your logged in session === the link of the username
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :) Thanks for fixes
Co-authored-by: Sean Brydon <sean@brydon.io>
Co-authored-by: Sean Brydon <sean@brydon.io>
after:
how to test
visit your own link on localhost
see "need help" button
click it
visit someone else's link on local host
don't see the "need help" button