Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate key in common.json #12543

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Conversation

Udit-takkar
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Nov 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2023 11:04am
cal 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 26, 2023 11:04am
cal-demo 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 26, 2023 11:04am
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2023 11:04am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2023 11:04am
qa ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2023 11:04am
ui ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2023 11:04am

Copy link
Contributor

github-actions bot commented Nov 26, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

Copy link
Contributor

github-actions bot commented Nov 26, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Nov 26, 2023

Current Playwright Test Results Summary

✅ 326 Passing - ⚠️ 24 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 11/26/2023 10:59:38am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: b578dab

Started: 11/26/2023 10:54:06am UTC

⚠️ Flakes

📄   apps/web/playwright/booking/selectQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Phone Question and Each Other Question Booking With Select Question and Number Question Select and Number not required
Retry 1Initial Attempt
0% (0) 0 / 236 runs
failed over last 7 days
1.27% (3) 3 / 236 runs
flaked over last 7 days

📄   apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Checkbox Group and Address not required
Retry 1Initial Attempt
0% (0) 0 / 243 runs
failed over last 7 days
1.23% (3) 3 / 243 runs
flaked over last 7 days
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and select Question Checkbox Group required and select required
Retry 1Initial Attempt
0% (0) 0 / 240 runs
failed over last 7 days
2.50% (6) 6 / 240 runs
flaked over last 7 days

📄   apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1Initial Attempt
0.40% (1) 1 / 248 run
failed over last 7 days
26.21% (65) 65 / 248 runs
flaked over last 7 days

📄   apps/web/playwright/locale.e2e.ts • 13 Flakes

Top 1 Common Error Messages

null

13 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
unauthorized user sees correct translations (de) should use correct translations and html attributes
Retry 1Initial Attempt
-33.06% (-82) -82 / 248 runs
failed over last 7 days
33.06% (82) 82 / 248 runs
flaked over last 7 days
unauthorized user sees correct translations (ar) should use correct translations and html attributes
Retry 1Initial Attempt
-33.06% (-82) -82 / 248 runs
failed over last 7 days
33.06% (82) 82 / 248 runs
flaked over last 7 days
unauthorized user sees correct translations (zh) should use correct translations and html attributes
Retry 1Initial Attempt
-33.06% (-82) -82 / 248 runs
failed over last 7 days
33.06% (82) 82 / 248 runs
flaked over last 7 days
unauthorized user sees correct translations (zh-CN) should use correct translations and html attributes
Retry 1Initial Attempt
-33.06% (-82) -82 / 248 runs
failed over last 7 days
33.06% (82) 82 / 248 runs
flaked over last 7 days
unauthorized user sees correct translations (zh-TW) should use correct translations and html attributes
Retry 1Initial Attempt
-33.06% (-82) -82 / 248 runs
failed over last 7 days
33.06% (82) 82 / 248 runs
flaked over last 7 days
unauthorized user sees correct translations (pt) should use correct translations and html attributes
Retry 1Initial Attempt
-33.06% (-82) -82 / 248 runs
failed over last 7 days
33.06% (82) 82 / 248 runs
flaked over last 7 days
unauthorized user sees correct translations (pt-br) should use correct translations and html attributes
Retry 1Initial Attempt
-32.66% (-81) -81 / 248 runs
failed over last 7 days
33.06% (82) 82 / 248 runs
flaked over last 7 days
unauthorized user sees correct translations (es-419) should use correct translations and html attributes
Retry 1Initial Attempt
-33.06% (-82) -82 / 248 runs
failed over last 7 days
33.06% (82) 82 / 248 runs
flaked over last 7 days
authorized user sees correct translations (de) should return correct translations and html attributes
Retry 1Initial Attempt
-31.71% (-78) -78 / 246 runs
failed over last 7 days
33.33% (82) 82 / 246 runs
flaked over last 7 days
authorized user sees correct translations (pt-br) should return correct translations and html attributes
Retry 1Initial Attempt
-31.40% (-76) -76 / 242 runs
failed over last 7 days
33.88% (82) 82 / 242 runs
flaked over last 7 days
authorized user sees correct translations (ar) should return correct translations and html attributes
Retry 1Initial Attempt
-33.90% (-80) -80 / 236 runs
failed over last 7 days
34.32% (81) 81 / 236 runs
flaked over last 7 days
authorized user sees changed translations (de->ar) should return correct translations and html attributes
Retry 1Initial Attempt
-12.82% (-30) -30 / 234 runs
failed over last 7 days
26.07% (61) 61 / 234 runs
flaked over last 7 days
authorized user sees changed translations (de->pt-BR) [locale1] should return correct translations and html attributes
Retry 1Initial Attempt
-14.29% (-29) -29 / 203 runs
failed over last 7 days
24.14% (49) 49 / 203 runs
flaked over last 7 days

📄   apps/web/playwright/teams.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams - NonOrg Can create a private team
Retry 1Initial Attempt
0% (0) 0 / 262 runs
failed over last 7 days
22.52% (59) 59 / 262 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests user -- future Different Locations Tests can add Attendee Phone Number location and book with it
Retry 1Initial Attempt
0% (0) 0 / 98 runs
failed over last 7 days
12.24% (12) 12 / 98 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-creation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization should be able to create an organization and complete onboarding
Retry 1Initial Attempt
2.47% (4) 4 / 162 runs
failed over last 7 days
95.68% (155) 155 / 162 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization Invitation (non verified)
Retry 1Initial Attempt
6.21% (10) 10 / 161 runs
failed over last 7 days
15.53% (25) 25 / 161 runs
flaked over last 7 days

📄   apps/web/playwright/team/team-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Team Invitation (non verified)
Retry 1Initial Attempt
2.36% (3) 3 / 127 runs
failed over last 7 days
13.39% (17) 17 / 127 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
11.07% (29) 29 / 262 runs
failed over last 7 days
84.35% (221) 221 / 262 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
1.14% (3) 3 / 264 runs
failed over last 7 days
67.05% (177) 177 / 264 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always good to have some i18n hygene, thanks!

@Udit-takkar Udit-takkar merged commit a48e7cb into main Nov 27, 2023
36 of 37 checks passed
@Udit-takkar Udit-takkar deleted the fix/remove-duplicate-keys branch November 27, 2023 13:53
jakazzy pushed a commit to jakazzy/cal.com that referenced this pull request Dec 5, 2023
* fix: remove duplicate key in common.json

* chore: add  both keys in same log
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Dec 21, 2023
* fix: remove duplicate key in common.json

* chore: add  both keys in same log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants