fix: cal video issues #12546
Merged
fix: cal video issues #12546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
No failed tests 🎉 |
Udit-takkar
commented
Nov 26, 2023
| @@ -214,7 +214,7 @@ export function VideoMeetingInfo(props: VideoMeetingInfo) { | |||
| <h3>{t("invitee_timezone")}:</h3> | |||
| <p>{booking.user?.timeZone}</p> | |||
| <h3>{t("when")}:</h3> | |||
| <p> | |||
| <p suppressHydrationWarning={true}> | |||
There was a problem hiding this comment.
Udit-takkar
commented
Nov 27, 2023
apps/web/server.js
Outdated
Comment on lines
1
to
23
| const { createServer } = require("https"); | ||
| const { parse } = require("url"); | ||
| const next = require("next"); | ||
| const fs = require("fs"); | ||
| const port = 3000; | ||
| const dev = process.env.NODE_ENV !== "production"; | ||
| const app = next({ dev }); | ||
| const handle = app.getRequestHandler(); | ||
|
|
||
| const httpsOptions = { | ||
| key: fs.readFileSync("./app.cal.local-key.pem"), | ||
| cert: fs.readFileSync("./app.cal.local.pem"), | ||
| }; | ||
|
|
||
| app.prepare().then(() => { | ||
| createServer(httpsOptions, async (req, res) => { | ||
| const parsedUrl = parse(req.url, true); | ||
| await handle(req, res, parsedUrl); | ||
| }).listen(port, (err) => { | ||
| if (err) throw err; | ||
| console.log(`ready - started server on url: https://app.cal.local:${port}`); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
This script is for serving nextjs server over https for testing organization's cal video meeting links
PeerRich
reviewed
Nov 27, 2023
PeerRich
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
looks good, need @hariombalhara for final review for org changes
PeerRich
previously approved these changes
Nov 27, 2023
There was a problem hiding this comment.
looks good, need @hariombalhara for final review for org changes
zomars
requested changes
Nov 27, 2023
zomars
approved these changes
Nov 28, 2023
jakazzy
pushed a commit
to jakazzy/cal.com
that referenced
this pull request
Dec 5, 2023
Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com>
hbjORbj
pushed a commit
to codemod-com/cal.com-demo
that referenced
this pull request
Dec 21, 2023
Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11136
Before:-
After:-