fix: rescheduling recurring events #12567
Conversation
|
@SomayChauhan is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
bookings
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Fifty-four Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
| export const EventDetails = ({ | ||
| event, | ||
| blocks = defaultEventDetailsBlocks, | ||
| rescheduleUid, |
There was a problem hiding this comment.
Can't we just use
const rescheduleUid = useBookerStore((state) => state.rescheduleUid);
In here instead of doing prop-drilling?
https://handbook.cal.com/engineering/best-practices/avoid-prop-drilling
There was a problem hiding this comment.
I tested it and it looked pretty good. The only thing I found was that the old rescheduled booking is still showing up on the booking detail page of the recurring event (booking/). @SomayChauhan Could you take a look at that?
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
What does this PR do?
an attempt to fix #12461
Before
Screencast.from.28-11-23.12.22.58.PM.IST.webm
After
Screencast.from.28-11-23.11.48.51.AM.IST.webm
The fix ensures that rescheduling a single booking in recurring-bookings behaves like rescheduling a normal booking.
Not confident if this is the right approach