Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add check for recording #12584

Merged
merged 2 commits into from
Nov 29, 2023
Merged

chore: add check for recording #12584

merged 2 commits into from
Nov 29, 2023

Conversation

Udit-takkar
Copy link
Contributor

Screenshot 2023-11-29 at 2 01 54 PM

view recordings -> we have isRecorded property marked as true

in case user wasn't logged in while recording or any other failure which couldn't update the isRecorded to true. user is unable to get the recording link so added a button

check for recordings -> isRecorded is marked as false but you can check if any recording exist for this daily vide room.

Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2023 9:28am
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2023 9:28am
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2023 9:28am
cal ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2023 9:28am
cal-demo ⬜️ Ignored (Inspect) Nov 29, 2023 9:28am
qa ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2023 9:28am
ui ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2023 9:28am

Copy link
Contributor

github-actions bot commented Nov 29, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

Copy link
Contributor

github-actions bot commented Nov 29, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Nov 29, 2023

Current Playwright Test Results Summary

✅ 336 Passing - ⚠️ 23 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 11/29/2023 09:34:44am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 9ac4427

Started: 11/29/2023 09:26:35am UTC

⚠️ Flakes

📄   apps/web/playwright/locale.e2e.ts • 13 Flakes

Top 1 Common Error Messages

null

13 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
unauthorized user sees correct translations (de) should use correct translations and html attributes
Retry 1Initial Attempt
-53.87% (-146) -146 / 271 runs
failed over last 7 days
53.87% (146) 146 / 271 runs
flaked over last 7 days
unauthorized user sees correct translations (ar) should use correct translations and html attributes
Retry 1Initial Attempt
-53.87% (-146) -146 / 271 runs
failed over last 7 days
53.87% (146) 146 / 271 runs
flaked over last 7 days
unauthorized user sees correct translations (zh) should use correct translations and html attributes
Retry 1Initial Attempt
-53.87% (-146) -146 / 271 runs
failed over last 7 days
53.87% (146) 146 / 271 runs
flaked over last 7 days
unauthorized user sees correct translations (zh-CN) should use correct translations and html attributes
Retry 1Initial Attempt
-53.87% (-146) -146 / 271 runs
failed over last 7 days
53.87% (146) 146 / 271 runs
flaked over last 7 days
unauthorized user sees correct translations (zh-TW) should use correct translations and html attributes
Retry 1Initial Attempt
-53.87% (-146) -146 / 271 runs
failed over last 7 days
53.87% (146) 146 / 271 runs
flaked over last 7 days
unauthorized user sees correct translations (pt) should use correct translations and html attributes
Retry 1Initial Attempt
-53.87% (-146) -146 / 271 runs
failed over last 7 days
53.87% (146) 146 / 271 runs
flaked over last 7 days
unauthorized user sees correct translations (pt-br) should use correct translations and html attributes
Retry 1Initial Attempt
-53.87% (-146) -146 / 271 runs
failed over last 7 days
53.87% (146) 146 / 271 runs
flaked over last 7 days
unauthorized user sees correct translations (es-419) should use correct translations and html attributes
Retry 1Initial Attempt
-53.68% (-146) -146 / 272 runs
failed over last 7 days
53.68% (146) 146 / 272 runs
flaked over last 7 days
authorized user sees correct translations (de) should return correct translations and html attributes
Retry 1Initial Attempt
-52.22% (-141) -141 / 270 runs
failed over last 7 days
54.07% (146) 146 / 270 runs
flaked over last 7 days
authorized user sees correct translations (pt-br) should return correct translations and html attributes
Retry 1Initial Attempt
-53.21% (-141) -141 / 265 runs
failed over last 7 days
55.09% (146) 146 / 265 runs
flaked over last 7 days
authorized user sees correct translations (ar) should return correct translations and html attributes
Retry 1Initial Attempt
-55.38% (-144) -144 / 260 runs
failed over last 7 days
55.77% (145) 145 / 260 runs
flaked over last 7 days
authorized user sees changed translations (de->ar) should return correct translations and html attributes
Retry 1Initial Attempt
-17.37% (-45) -45 / 259 runs
failed over last 7 days
39.38% (102) 102 / 259 runs
flaked over last 7 days
authorized user sees changed translations (de->pt-BR) [locale1] should return correct translations and html attributes
Retry 1Initial Attempt
-21.78% (-44) -44 / 202 runs
failed over last 7 days
37.62% (76) 76 / 202 runs
flaked over last 7 days

📄   apps/web/playwright/booking/longTextQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Long Text Question and Each Other Question Long Text required and Address not required
Retry 1Initial Attempt
1.82% (5) 5 / 275 runs
failed over last 7 days
1.09% (3) 3 / 275 runs
flaked over last 7 days

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration when enabling Stripe, team credentialId is included
Retry 1Initial Attempt
5.88% (17) 17 / 289 runs
failed over last 7 days
2.08% (6) 6 / 289 runs
flaked over last 7 days

📄   apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and select Question Phone and select required
Retry 1Initial Attempt
0.37% (1) 1 / 273 run
failed over last 7 days
1.47% (4) 4 / 273 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests user -- legacy Different Locations Tests Can add Organzer Phone Number location and book with it
Retry 1Initial Attempt
0.44% (1) 1 / 228 run
failed over last 7 days
2.63% (6) 6 / 228 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-creation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization should be able to create an organization and complete onboarding
Retry 2Retry 1Initial Attempt
2.88% (8) 8 / 278 runs
failed over last 7 days
94.24% (262) 262 / 278 runs
flaked over last 7 days

📄   apps/web/playwright/teams.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams - NonOrg Can create a private team
Retry 1Initial Attempt
0% (0) 0 / 297 runs
failed over last 7 days
24.24% (72) 72 / 297 runs
flaked over last 7 days

📄   apps/web/playwright/booking/multipleEmailQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Multiple Email Question and Each Other Question Booking With Multiple email Question and phone Question Multiple email required and Phone required
Retry 1Initial Attempt
0.72% (2) 2 / 277 runs
failed over last 7 days
2.17% (6) 6 / 277 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
6.10% (18) 18 / 295 runs
failed over last 7 days
90.51% (267) 267 / 295 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
1.01% (3) 3 / 297 runs
failed over last 7 days
74.75% (222) 222 / 297 runs
flaked over last 7 days

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Router URL should work
Retry 2Retry 1Initial Attempt
0% (0) 0 / 283 runs
failed over last 7 days
10.95% (31) 31 / 283 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, good edge case!

@PeerRich PeerRich merged commit 45c4f47 into main Nov 29, 2023
36 checks passed
@PeerRich PeerRich deleted the chore/add-check-for-recordings branch November 29, 2023 09:54
jakazzy pushed a commit to jakazzy/cal.com that referenced this pull request Dec 5, 2023
Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com>
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Dec 21, 2023
Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants