Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(.env.example): use proper openssl rand byte size #12587

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

iperzic
Copy link
Contributor

@iperzic iperzic commented Nov 29, 2023

What does this PR do?

The documented length for generating random key was not aligned with the example given below.

Leftover from: #12160

Requirement/Documentation

None

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

No need for testing, the change only applies to .env.example comment.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

Copy link

vercel bot commented Nov 29, 2023

@iperzic is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the ❗️ .env changes contains changes to env variables label Nov 29, 2023
Copy link
Contributor

github-actions bot commented Nov 29, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

Copy link
Contributor

github-actions bot commented Nov 29, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@Udit-takkar Udit-takkar enabled auto-merge (squash) November 29, 2023 14:53
@Udit-takkar Udit-takkar merged commit bae3bd7 into calcom:main Nov 29, 2023
27 of 35 checks passed
@iperzic iperzic deleted the docs/fix-env-example-typo branch December 2, 2023 07:55
jakazzy pushed a commit to jakazzy/cal.com that referenced this pull request Dec 5, 2023
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❗️ .env changes contains changes to env variables
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants