fix: updating workflow with new step and new active event type #12592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
CarinaWolli
commented
Nov 29, 2023
| @@ -629,11 +621,9 @@ export const updateHandler = async ({ ctx, input }: UpdateOptions) => { | |||
| }); | |||
|
|
|||
| if (addedSteps) { | |||
| const eventTypesToCreateReminders = activeOn.map((activeEventType) => { | |||
There was a problem hiding this comment.
this resulted in having null and undefined values in eventTypesToCreateReminders which made booking.findMany() from Line 644 fail
CarinaWolli
added
workflows
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 336 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 11/29/2023 05:18:31pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 82c2e6a Started: 11/29/2023 05:09:37pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking with Seats Attendees can cancel a seated event time slot
Retry 2 • Retry 1 • Initial Attempt |
0.34% (1)1 / 294 runfailed over last 7 days |
2.04% (6)6 / 294 runsflaked over last 7 days |
📄 apps/web/playwright/booking/selectQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Select Question and Number Question Select required and Number required
Retry 1 • Initial Attempt |
0% (0)0 / 294 runsfailed over last 7 days |
2.72% (8)8 / 294 runsflaked over last 7 days |
📄 apps/web/playwright/locale.e2e.ts • 13 Flakes
Top 1 Common Error Messages
|
|
13 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
unauthorized user sees correct translations (de) should use correct translations and html attributes
Retry 2 • Retry 1 • Initial Attempt |
-55.70% (-166)-166 / 298 runsfailed over last 7 days |
55.70% (166)166 / 298 runsflaked over last 7 days |
|
unauthorized user sees correct translations (ar) should use correct translations and html attributes
Retry 2 • Retry 1 • Initial Attempt |
-55.70% (-166)-166 / 298 runsfailed over last 7 days |
55.70% (166)166 / 298 runsflaked over last 7 days |
|
unauthorized user sees correct translations (zh) should use correct translations and html attributes
Retry 2 • Retry 1 • Initial Attempt |
-55.70% (-166)-166 / 298 runsfailed over last 7 days |
55.70% (166)166 / 298 runsflaked over last 7 days |
|
unauthorized user sees correct translations (zh-CN) should use correct translations and html attributes
Retry 2 • Retry 1 • Initial Attempt |
-55.70% (-166)-166 / 298 runsfailed over last 7 days |
55.70% (166)166 / 298 runsflaked over last 7 days |
|
unauthorized user sees correct translations (zh-TW) should use correct translations and html attributes
Retry 2 • Retry 1 • Initial Attempt |
-55.70% (-166)-166 / 298 runsfailed over last 7 days |
55.70% (166)166 / 298 runsflaked over last 7 days |
|
unauthorized user sees correct translations (pt) should use correct translations and html attributes
Retry 2 • Retry 1 • Initial Attempt |
-55.70% (-166)-166 / 298 runsfailed over last 7 days |
55.70% (166)166 / 298 runsflaked over last 7 days |
|
unauthorized user sees correct translations (pt-br) should use correct translations and html attributes
Retry 2 • Retry 1 • Initial Attempt |
-55.70% (-166)-166 / 298 runsfailed over last 7 days |
55.70% (166)166 / 298 runsflaked over last 7 days |
|
unauthorized user sees correct translations (es-419) should use correct translations and html attributes
Retry 2 • Retry 1 • Initial Attempt |
-55.52% (-166)-166 / 299 runsfailed over last 7 days |
55.52% (166)166 / 299 runsflaked over last 7 days |
|
authorized user sees correct translations (de) should return correct translations and html attributes
Retry 2 • Retry 1 • Initial Attempt |
-53.87% (-160)-160 / 297 runsfailed over last 7 days |
55.89% (166)166 / 297 runsflaked over last 7 days |
|
authorized user sees correct translations (pt-br) should return correct translations and html attributes
Retry 2 • Retry 1 • Initial Attempt |
-55.33% (-161)-161 / 291 runsfailed over last 7 days |
57.04% (166)166 / 291 runsflaked over last 7 days |
|
authorized user sees correct translations (ar) should return correct translations and html attributes
Retry 2 • Retry 1 • Initial Attempt |
-57.34% (-164)-164 / 286 runsfailed over last 7 days |
57.69% (165)165 / 286 runsflaked over last 7 days |
|
authorized user sees changed translations (de->ar) should return correct translations and html attributes
Retry 2 • Retry 1 • Initial Attempt |
-18.25% (-52)-52 / 285 runsfailed over last 7 days |
40.70% (116)116 / 285 runsflaked over last 7 days |
|
authorized user sees changed translations (de->pt-BR) [locale1] should return correct translations and html attributes
Retry 2 • Retry 1 • Initial Attempt |
-22.17% (-49)-49 / 221 runsfailed over last 7 days |
39.82% (88)88 / 221 runsflaked over last 7 days |
📄 apps/web/playwright/booking/radioGroupQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and Multi email Question Radio and Multi email not required
Retry 1 • Initial Attempt |
0% (0)0 / 297 runsfailed over last 7 days |
1.01% (3)3 / 297 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user -- legacy Different Locations Tests Can remove location from multiple locations that are saved
Retry 1 • Initial Attempt |
0% (0)0 / 255 runsfailed over last 7 days |
3.53% (9)9 / 255 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Preview Preview - embed-core should load
Retry 1 • Initial Attempt |
0% (0)0 / 320 runsfailed over last 7 days |
22.81% (73)73 / 320 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
5.90% (19)19 / 322 runsfailed over last 7 days |
90.99% (293)293 / 322 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
0.93% (3)3 / 324 runsfailed over last 7 days |
74.38% (241)241 / 324 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-creation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Organization should be able to create an organization and complete onboarding
Retry 2 • Retry 1 • Initial Attempt |
2.61% (8)8 / 306 runsfailed over last 7 days |
94.44% (289)289 / 306 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
0.94% (3)3 / 319 runsfailed over last 7 days |
29.15% (93)93 / 319 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Organization Invitation (non verified)
Retry 1 • Initial Attempt |
10.16% (31)31 / 305 runsfailed over last 7 days |
21.31% (65)65 / 305 runsflaked over last 7 days |
Udit-takkar
approved these changes
Nov 29, 2023
jakazzy
pushed a commit
to jakazzy/cal.com
that referenced
this pull request
Dec 5, 2023
…m#12592) * correctly filter event types to avoid null values * clean up all filters * re-add reverted fix --------- Co-authored-by: CarinaWolli <wollencarina@gmail.com>
hbjORbj
pushed a commit
to codemod-com/cal.com-demo
that referenced
this pull request
Dec 21, 2023
…m#12592) * correctly filter event types to avoid null values * clean up all filters * re-add reverted fix --------- Co-authored-by: CarinaWolli <wollencarina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes issue that a workflow with an added step and a new active event types couldn't be saved because
booking.findMany()failed.Type of change
How should this be tested?