chore: improve invitation form validation #12594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
ThyMinimalDev
commented
Nov 29, 2023
| @@ -213,8 +218,10 @@ export default function MemberInvitationModal(props: MemberInvitationModalProps) | |||
| name="emailOrUsername" | |||
| control={newMemberFormMethods.control} | |||
| rules={{ | |||
| required: t("enter_email_or_username"), | |||
| required: isOrg ? t("enter_email") : t("enter_email_or_username"), | |||
There was a problem hiding this comment.
org can only invite by email
ThyMinimalDev
commented
Nov 29, 2023
| @@ -241,7 +247,14 @@ export default function MemberInvitationModal(props: MemberInvitationModalProps) | |||
| name="emailOrUsername" | |||
| control={newMemberFormMethods.control} | |||
| rules={{ | |||
| required: t("enter_email_or_username"), | |||
| required: t("enter_email"), | |||
There was a problem hiding this comment.
Bulk invite only by email
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 74 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 11/29/2023 07:31:57pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 2617b6a Started: 11/29/2023 07:27:27pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 2 • Retry 1 • Initial Attempt |
0.33% (1)1 / 304 runfailed over last 7 days |
25.66% (78)78 / 304 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration When event is paid and confirmed Paid and confirmed booking should be able to be rescheduled
Retry 1 • Initial Attempt |
0% (0)0 / 304 runsfailed over last 7 days |
2.30% (7)7 / 304 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user -- legacy Different Locations Tests can add Attendee Phone Number location and book with it
Retry 1 • Initial Attempt |
0.38% (1)1 / 261 runfailed over last 7 days |
3.07% (8)8 / 261 runsflaked over last 7 days |
jakazzy
pushed a commit
to jakazzy/cal.com
that referenced
this pull request
Dec 5, 2023
* chore: improve invitation form validation * fixup! chore: improve invitation form validation * fixup! fixup! chore: improve invitation form validation
hbjORbj
pushed a commit
to codemod-com/cal.com-demo
that referenced
this pull request
Dec 21, 2023
* chore: improve invitation form validation * fixup! chore: improve invitation form validation * fixup! fixup! chore: improve invitation form validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
improve form validation of the team/org invitation form
Type of change
How should this be tested?
send invitations to members for teams / orgs
Mandatory Tasks