fix: attempting to book meeting in the past #12597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
github-actions
bot
added
bookings
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 336 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 11/30/2023 05:30:26pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 0206220 Started: 11/30/2023 05:21:08pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking with Seats User can create a seated event (2 seats as example)
Retry 1 • Initial Attempt |
0.76% (2)2 / 264 runsfailed over last 7 days |
4.17% (11)11 / 264 runsflaked over last 7 days |
📄 apps/web/playwright/booking/selectQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Select Question and Phone Question Select required and select required
Retry 1 • Initial Attempt |
0% (0)0 / 265 runsfailed over last 7 days |
3.02% (8)8 / 265 runsflaked over last 7 days |
📄 apps/web/playwright/booking/longTextQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Phone Question Long Text and Phone required
Retry 1 • Initial Attempt |
0.37% (1)1 / 269 runfailed over last 7 days |
0.74% (2)2 / 269 runsflaked over last 7 days |
📄 apps/web/playwright/booking/radioGroupQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and Long text Question Radio and Long text not required
Retry 1 • Initial Attempt |
0.37% (1)1 / 269 runfailed over last 7 days |
2.23% (6)6 / 269 runsflaked over last 7 days |
📄 apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Address Question and Each Other Question Booking With Address Question and Checkbox Question Address required and checkbox required
Retry 1 • Initial Attempt |
3.16% (9)9 / 285 runsfailed over last 7 days |
0.35% (1)1 / 285 runflaked over last 7 days |
|
Booking With Address Question and Each Other Question Booking With Address Question and Phone Question Address and Phone not required
Retry 1 • Initial Attempt |
0% (0)0 / 276 runsfailed over last 7 days |
1.45% (4)4 / 276 runsflaked over last 7 days |
📄 apps/web/playwright/locale.e2e.ts • 13 Flakes
Top 1 Common Error Messages
|
|
13 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
unauthorized user sees correct translations (de) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-68.75% (-187)-187 / 272 runsfailed over last 7 days |
68.75% (187)187 / 272 runsflaked over last 7 days |
|
unauthorized user sees correct translations (ar) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-68.75% (-187)-187 / 272 runsfailed over last 7 days |
68.75% (187)187 / 272 runsflaked over last 7 days |
|
unauthorized user sees correct translations (zh) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-68.75% (-187)-187 / 272 runsfailed over last 7 days |
68.75% (187)187 / 272 runsflaked over last 7 days |
|
unauthorized user sees correct translations (zh-CN) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-68.75% (-187)-187 / 272 runsfailed over last 7 days |
68.75% (187)187 / 272 runsflaked over last 7 days |
|
unauthorized user sees correct translations (zh-TW) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-68.75% (-187)-187 / 272 runsfailed over last 7 days |
68.75% (187)187 / 272 runsflaked over last 7 days |
|
unauthorized user sees correct translations (pt) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-68.75% (-187)-187 / 272 runsfailed over last 7 days |
68.75% (187)187 / 272 runsflaked over last 7 days |
|
unauthorized user sees correct translations (pt-br) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-68.75% (-187)-187 / 272 runsfailed over last 7 days |
68.75% (187)187 / 272 runsflaked over last 7 days |
|
unauthorized user sees correct translations (es-419) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-68.75% (-187)-187 / 272 runsfailed over last 7 days |
68.75% (187)187 / 272 runsflaked over last 7 days |
|
authorized user sees correct translations (de) should return correct translations and html attributes
Retry 1 • Initial Attempt |
-66.91% (-182)-182 / 272 runsfailed over last 7 days |
68.75% (187)187 / 272 runsflaked over last 7 days |
|
authorized user sees correct translations (pt-br) should return correct translations and html attributes
Retry 1 • Initial Attempt |
-68.91% (-184)-184 / 267 runsfailed over last 7 days |
70.04% (187)187 / 267 runsflaked over last 7 days |
|
authorized user sees correct translations (ar) should return correct translations and html attributes
Retry 1 • Initial Attempt |
-70.45% (-186)-186 / 264 runsfailed over last 7 days |
70.83% (187)187 / 264 runsflaked over last 7 days |
|
authorized user sees changed translations (de->ar) should return correct translations and html attributes
Retry 1 • Initial Attempt |
-20.53% (-54)-54 / 263 runsfailed over last 7 days |
47.53% (125)125 / 263 runsflaked over last 7 days |
|
authorized user sees changed translations (de->pt-BR) [locale1] should return correct translations and html attributes
Retry 1 • Initial Attempt |
-23.96% (-46)-46 / 192 runsfailed over last 7 days |
47.40% (91)91 / 192 runsflaked over last 7 days |
📄 apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and checkbox group Question Phone required and checkbox group not required
Retry 2 • Retry 1 • Initial Attempt |
0% (0)0 / 273 runsfailed over last 7 days |
2.56% (7)7 / 273 runsflaked over last 7 days |
📄 apps/web/playwright/change-username.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Change username on settings User can change username
Retry 1 • Initial Attempt |
0.38% (1)1 / 266 runfailed over last 7 days |
5.64% (15)15 / 266 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 4 Flakes
Top 1 Common Error Messages
|
|
4 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
0.69% (2)2 / 289 runsfailed over last 7 days |
48.79% (141)141 / 289 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt |
3.11% (9)9 / 289 runsfailed over last 7 days |
94.12% (272)272 / 289 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
3.10% (9)9 / 290 runsfailed over last 7 days |
32.76% (95)95 / 290 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
0.34% (1)1 / 290 runfailed over last 7 days |
77.24% (224)224 / 290 runsflaked over last 7 days |
📄 apps/web/playwright/insights.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Insights should test download button
Retry 1 • Initial Attempt |
0.35% (1)1 / 288 runfailed over last 7 days |
6.25% (18)18 / 288 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
0.35% (1)1 / 287 runfailed over last 7 days |
31.71% (91)91 / 287 runsflaked over last 7 days |
Abdel-Monaam-Aouini
approved these changes
Nov 29, 2023
exception
approved these changes
Nov 30, 2023
Udit-takkar
approved these changes
Nov 30, 2023
jakazzy
pushed a commit
to jakazzy/cal.com
that referenced
this pull request
Dec 5, 2023
Co-authored-by: CarinaWolli <wollencarina@gmail.com> Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
hbjORbj
pushed a commit
to codemod-com/cal.com-demo
that referenced
this pull request
Dec 21, 2023
Co-authored-by: CarinaWolli <wollencarina@gmail.com> Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes 'Attempting to booking meeting in the past error' in
slots.getSchedule:This happened when the minimum booking notice was set to 0 minutes. And the first available slot is on the exact same time as the current time.
Fixes #7230
Type of change