Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [app-router-migration-4]: apps/categories page #12619

Conversation

DmytroHryshyn
Copy link
Contributor

@DmytroHryshyn DmytroHryshyn commented Dec 1, 2023

What does this PR do?

Migrates apps/categories, apps/categories/[category] pages.

This PR depends on #12593

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Copy link

vercel bot commented Dec 1, 2023

@DmytroHryshyn is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Dec 1, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@github-actions github-actions bot added the ❗️ .env changes contains changes to env variables label Dec 1, 2023
@DmytroHryshyn DmytroHryshyn changed the title Chore/migrate apps/categories apps/categories/ category pages chore: [app-router-migration-4]: apps/categories page Dec 1, 2023
@PeerRich PeerRich added High priority Created by Linear-GitHub Sync devops labels Dec 1, 2023
@DmytroHryshyn DmytroHryshyn marked this pull request as ready for review December 6, 2023 17:51
@DmytroHryshyn DmytroHryshyn force-pushed the chore/migrate-apps/categories-apps/categories/_category_-pages branch from 9000e9b to 4789ed1 Compare December 6, 2023 17:53
Copy link
Contributor

github-actions bot commented Dec 6, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/bookings/[status] 316.83 KB 480.79 KB 137.37% (🟡 +0.84%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@DmytroHryshyn DmytroHryshyn force-pushed the chore/migrate-apps/categories-apps/categories/_category_-pages branch from 4789ed1 to 633a95b Compare December 8, 2023 11:04
Copy link
Member

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the reason but I am seeing a consistent crash on accessing http://app.cal.local:3000/apps/categories with future mode.
https://www.loom.com/share/66d37da1d31940c39691f04d7e695e0a

@DmytroHryshyn DmytroHryshyn force-pushed the chore/migrate-apps/categories-apps/categories/_category_-pages branch from 9e6bb1f to 317b43b Compare December 12, 2023 11:10
@DmytroHryshyn
Copy link
Contributor Author

I don't know the reason but I am seeing a consistent crash on accessing http://app.cal.local:3000/apps/categories with future mode. https://www.loom.com/share/66d37da1d31940c39691f04d7e695e0a

This issue can be related to vercel/next.js#54708. App dir router memory consumption is significantly higher then for Pages dir, but this does not affect production build, this is only dev server problem. It can be temporarily fixed by adding NODE_OPTIONS="--max-old-space-size=8192" before yarn dev command. We are researching if there is better fix for this.

Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zomars zomars merged commit add6ffd into calcom:main Dec 12, 2023
32 of 39 checks passed
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops ❗️ .env changes contains changes to env variables High priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants