Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [app-router-migration-3] apps/[slug]/index, apps/[slug]/setup #12620

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

DmytroHryshyn
Copy link
Contributor

What does this PR do?

Migrates apps/[slug]/, apps/[slug]/setup pages
This PR depends on #12593

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Copy link

vercel bot commented Dec 1, 2023

@DmytroHryshyn is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Dec 1, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@github-actions github-actions bot added the ❗️ .env changes contains changes to env variables label Dec 1, 2023
@DmytroHryshyn DmytroHryshyn changed the title Chore/migrate apps slug page chore: [app-router-migration-3] apps/[slug]/index, apps/[slug]/setup Dec 1, 2023
Copy link
Contributor

github-actions bot commented Dec 1, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 163.9 KB (🟡 +711 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@DmytroHryshyn DmytroHryshyn marked this pull request as ready for review December 1, 2023 17:34
@PeerRich PeerRich added the Medium priority Created by Linear-GitHub Sync label Dec 1, 2023
@PeerRich PeerRich requested review from zomars and a team December 1, 2023 18:19
@PeerRich PeerRich added High priority Created by Linear-GitHub Sync devops labels Dec 1, 2023
@DmytroHryshyn DmytroHryshyn force-pushed the chore/migrate-apps-slug-page branch 2 times, most recently from 3d7740d to e1a1ce4 Compare December 8, 2023 10:44
@zomars
Copy link
Member

zomars commented Dec 11, 2023

Merge activity

  • Dec 11, 3:11 PM: Graphite failed to merge this pull request due to internal failures. Try your merge again, or report a bug if you see this consistently.

@zomars zomars merged commit 098d41f into calcom:main Dec 11, 2023
32 of 40 checks passed
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops ❗️ .env changes contains changes to env variables High priority Created by Linear-GitHub Sync Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants