chore: upgrade storybook 7.6.3 + use @storybook/nextjs #12673
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Thirteen Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 348 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 12/04/2023 10:15:40am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 982f315 Started: 12/04/2023 10:07:45am UTC
|
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user -- future Different Locations Tests Can remove location from multiple locations that are saved
Retry 1 • Initial Attempt |
0% (0)0 / 322 runsfailed over last 7 days |
2.48% (8)8 / 322 runsflaked over last 7 days |
|
Event Types tests user -- legacy enabling recurring event comes with default options
Retry 2 • Retry 1 • Initial Attempt |
0.62% (2)2 / 321 runsfailed over last 7 days |
10.59% (34)34 / 321 runsflaked over last 7 days |
📄 apps/web/playwright/teams.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams - NonOrg Can create a private team
Retry 1 • Initial Attempt |
0% (0)0 / 330 runsfailed over last 7 days |
24.24% (80)80 / 330 runsflaked over last 7 days |
|
Teams - Org Can create teams via Wizard
Retry 1 • Initial Attempt |
3.33% (11)11 / 330 runsfailed over last 7 days |
11.82% (39)39 / 330 runsflaked over last 7 days |
📄 apps/web/playwright/team/team-invitation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Team Invitation (non verified)
Retry 1 • Initial Attempt |
1.83% (6)6 / 328 runsfailed over last 7 days |
28.96% (95)95 / 328 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully login flow user & logout using dashboard
Retry 1 • Initial Attempt |
0% (0)0 / 318 runsfailed over last 7 days |
5.97% (19)19 / 318 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
5.72% (19)19 / 332 runsfailed over last 7 days |
90.96% (302)302 / 332 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
2.41% (8)8 / 332 runsfailed over last 7 days |
76.81% (255)255 / 332 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-creation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Organization should be able to create an organization and complete onboarding
Retry 1 • Initial Attempt |
14.46% (48)48 / 332 runsfailed over last 7 days |
66.27% (220)220 / 332 runsflaked over last 7 days |
📄 apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Phone required and Address not required
Retry 1 • Initial Attempt |
1.55% (5)5 / 322 runsfailed over last 7 days |
4.04% (13)13 / 322 runsflaked over last 7 days |
ThyMinimalDev
added
⬆️ dependencies
| @@ -1,4 +1,7 @@ | |||
| import { TooltipProvider } from "@radix-ui/react-tooltip"; | |||
| import { | |||
| Tooltip, | |||
There was a problem hiding this comment.
import was missing
| parameters={{ | ||
| nextjs: { | ||
| appDirectory: true, | ||
| }, | ||
| }} |
There was a problem hiding this comment.
specify that this component uses features from next.js 13+ imported from next/navigation
| parameters={{ | ||
| nextjs: { | ||
| appDirectory: true, | ||
| }, | ||
| }} |
There was a problem hiding this comment.
specify that this component uses features from next.js 13+ imported from next/navigation
| parameters={{ | ||
| nextjs: { | ||
| appDirectory: true, | ||
| }, | ||
| }} |
There was a problem hiding this comment.
specify that this component uses features from next.js 13+ imported from next/navigation
| @@ -74,13 +70,15 @@ export const Template = (args) => <Calendar {...args} />; | |||
| }, | |||
| }}> | |||
| {({ ...args }) => ( | |||
| <TooltipProvider> | |||
There was a problem hiding this comment.
calendar uses tooltips
| parameters={{ | ||
| nextjs: { | ||
| appDirectory: true, | ||
| }, | ||
| }} |
There was a problem hiding this comment.
specify that this component uses features from next.js 13+ imported from next/navigation
| userEvent.type(colorInput, newColorValue); | ||
| }); | ||
|
|
||
| await act(async () => userEvent.type(colorInput, newColorValue)); |
There was a problem hiding this comment.
fix flaky test
There was a problem hiding this comment.
this wasn't awaiting properly for the typing event to be over
* chore: upgrade storybook 7.6.3 + use @storybook/nextjs * fix: color picker tests
* chore: upgrade storybook 7.6.3 + use @storybook/nextjs * fix: color picker tests
* chore: upgrade storybook 7.6.3 + use @storybook/nextjs * fix: color picker tests
What does this PR do?
Upgrade storybook to latest version + use @storybook/nextjs + fix breaking changes
Type of change
How should this be tested?
Mandatory Tasks