fix: Edit Location modal fields truncates on mobile view #12684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ujjwal2505 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
ujjwal2505
changed the title
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Udit-takkar
reviewed
Dec 6, 2023
Udit-takkar
reviewed
Dec 6, 2023
| @@ -382,7 +382,7 @@ export const EditLocationDialog = (props: ISetLocationDialog) => { | |||
| }} | |||
| /> | |||
| {selectedLocation && LocationOptions} | |||
| <DialogFooter className="mt-4"> | |||
| <DialogFooter className="relative"> | |||
There was a problem hiding this comment.
@ujjwal2505 this seem to be working. can you pull the changes and test it once
There was a problem hiding this comment.
I tested the code and it is working. We can close the issue.
Udit-takkar
approved these changes
Dec 7, 2023
hbjORbj
pushed a commit
to codemod-com/cal.com-demo
that referenced
this pull request
Dec 21, 2023
* fix calcom#12640: Edit Location modal fields truncates on mobile * chore: fix dialog --------- Co-authored-by: Udit Takkar <udit222001@gmail.com> Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
haranrk
pushed a commit
to haranrk/cal.com
that referenced
this pull request
Jan 4, 2024
* fix calcom#12640: Edit Location modal fields truncates on mobile * chore: fix dialog --------- Co-authored-by: Udit Takkar <udit222001@gmail.com> Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12640