fix: rr-host booked outside of availability #12704
Merged
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 7 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 12/08/2023 01:30:10am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 2cd281f Started: 12/08/2023 01:29:31am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Organization should be able to create an organization and complete onboarding
Retry 1 • Initial Attempt |
33.61% (81)81 / 241 runsfailed over last 7 days |
50.21% (121)121 / 241 runsflaked over last 7 days |
alishaz-polymath
previously approved these changes
Dec 7, 2023
emrysal
requested changes
Dec 7, 2023
6 tasks
emrysal
approved these changes
Dec 8, 2023
hbjORbj
pushed a commit
to codemod-com/cal.com-demo
that referenced
this pull request
Dec 21, 2023
* correctly query overlapping bookings * remove console.log * fix getting busy bookings for getAvailableSlots --------- Co-authored-by: CarinaWolli <wollencarina@gmail.com>
haranrk
pushed a commit
to haranrk/cal.com
that referenced
this pull request
Jan 4, 2024
* correctly query overlapping bookings * remove console.log * fix getting busy bookings for getAvailableSlots --------- Co-authored-by: CarinaWolli <wollencarina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the follow issue:
I have two rr-hosts (teampro, teamfree). Got these two personal bookings for teampro in the db (see screenshot, first two bookings). If teamfree doesn't have any availability, the 10AM slot on dez 12 (Melbourne) is not showing (that's correct). If teamfree is available the slot shows (as it should) BUT if it is teampro's round robin turn, it books teampro
The issue was the getBusyTimes didn't return the bookings because we were filtering the bookings like that:
{
"startTime":{"gte":"2023-12-11T23:00:00.000Z"},
"endTime":{"lte":"2023-12-11T23:15:00.000Z"},
}
Type of change