fix: Allow lowercase/uppercase/mixedcase access with org team event booking page #12721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 364 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 12/12/2023 09:40:13pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 16bc41b Started: 12/12/2023 09:31:00pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Select Question and multiselect Question Select required and multiselect text required
Retry 1 • Initial Attempt |
0% (0)0 / 196 runsfailed over last 7 days |
2.55% (5)5 / 196 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user -- legacy enabling recurring event comes with default options
Retry 2 • Retry 1 • Initial Attempt |
2.63% (5)5 / 190 runsfailed over last 7 days |
13.68% (26)26 / 190 runsflaked over last 7 days |
📄 apps/web/playwright/booking/phoneQuestion.e2e.ts • 4 Flakes
Top 1 Common Error Messages
|
|
4 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and Long text Question Phone and Long text required
Retry 1 • Initial Attempt |
0.50% (1)1 / 201 runfailed over last 7 days |
1.99% (4)4 / 201 runsflaked over last 7 days |
|
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and Long text Question Phone required and Long text not required
Retry 1 • Initial Attempt |
0.50% (1)1 / 201 runfailed over last 7 days |
3.48% (7)7 / 201 runsflaked over last 7 days |
|
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and Multi email Question Phone and Multi email required
Retry 1 • Initial Attempt |
0.50% (1)1 / 200 runfailed over last 7 days |
3% (6)6 / 200 runsflaked over last 7 days |
|
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and Multi email Question Phone required and Multi email not required
Retry 1 • Initial Attempt |
0.50% (1)1 / 200 runfailed over last 7 days |
5.50% (11)11 / 200 runsflaked over last 7 days |
📄 apps/web/playwright/team/team-invitation.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Team Invitation (non verified)
Retry 2 • Retry 1 • Initial Attempt |
5.67% (11)11 / 194 runsfailed over last 7 days |
87.63% (170)170 / 194 runsflaked over last 7 days |
|
Team Invitation (verified)
Retry 1 • Initial Attempt |
0.52% (1)1 / 194 runfailed over last 7 days |
87.63% (170)170 / 194 runsflaked over last 7 days |
📄 apps/web/playwright/oauth-provider.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
OAuth Provider should create valid access toke & refresh token for team
Retry 1 • Initial Attempt |
1.40% (3)3 / 214 runsfailed over last 7 days |
18.69% (40)40 / 214 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Organization Invitation (verified)
Retry 1 • Initial Attempt |
0.95% (2)2 / 211 runsfailed over last 7 days |
8.53% (18)18 / 211 runsflaked over last 7 days |
📄 apps/web/playwright/change-username.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Change username on settings User can change username
Retry 1 • Initial Attempt |
0% (0)0 / 199 runsfailed over last 7 days |
17.09% (34)34 / 199 runsflaked over last 7 days |
📄 apps/web/playwright/embed-code-generator.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Embed Code Generator Tests Non-Organization Event Types Page open Embed Dialog and choose Inline for First Event Type
Retry 1 • Initial Attempt |
2.02% (4)4 / 198 runsfailed over last 7 days |
2.53% (5)5 / 198 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
FORM_SUBMITTED on submitting user form, triggers user webhook
Retry 1 • Initial Attempt |
1% (2)2 / 200 runsfailed over last 7 days |
8% (16)16 / 200 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
5.42% (11)11 / 203 runsfailed over last 7 days |
90.64% (184)184 / 203 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
0.50% (1)1 / 202 runfailed over last 7 days |
79.70% (161)161 / 202 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Router URL should work
Retry 1 • Initial Attempt |
0% (0)0 / 200 runsfailed over last 7 days |
7% (14)14 / 200 runsflaked over last 7 days |
hariombalhara
force-pushed
the
12-11-Fix_any_case_access_with_org_team_events
branch
from
a655149
to
c644671
Compare
hariombalhara
force-pushed
the
12-11-Fix_any_case_access_with_org_team_events
branch
from
60a9705
to
37b9159
Compare
hariombalhara
changed the title
hariombalhara
force-pushed
the
12-11-Fix_any_case_access_with_org_team_events
branch
from
37b9159
to
e8bc892
Compare
CarinaWolli
approved these changes
Dec 11, 2023
3 tasks
hbjORbj
pushed a commit
to codemod-com/cal.com-demo
that referenced
this pull request
Dec 21, 2023
…ooking page (calcom#12721) Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow team event booking page for an org to be accessed in all cases.
Fixes #11719
Type of change
How should this be tested?
marketingin it.syncuporg1.cal.local:3000/Marketing/syncup and org1.cal.local:3000/MARketing/syncup and org1.cal.local:3000/marketing/syncup - All of these should work
Mandatory Tasks