Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 500 error on email conflict #12725

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Conversation

emrysal
Copy link
Contributor

@emrysal emrysal commented Dec 11, 2023

What does this PR do?

Fixes a 500 Internal Error when trying to change to an email that already exists (duplicate)

Copy link

vercel bot commented Dec 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 2:19am
dev ❌ Failed (Inspect) Dec 13, 2023 2:19am
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2023 2:19am
cal ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2023 2:19am
cal-demo ⬜️ Ignored (Inspect) Dec 13, 2023 2:19am
qa ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2023 2:19am
ui ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2023 2:19am

Copy link
Contributor

github-actions bot commented Dec 11, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

Copy link

deploysentinel bot commented Dec 11, 2023

Current Playwright Test Results Summary

✅ 353 Passing - ⚠️ 28 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 12/13/2023 02:22:58am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: ea32a0c

Started: 12/13/2023 02:14:37am UTC

⚠️ Flakes

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Paid booking should be able to be cancelled
Retry 1Initial Attempt
0% (0) 0 / 185 runs
failed over last 7 days
3.24% (6) 6 / 185 runs
flaked over last 7 days

📄   apps/web/playwright/team/team-invitation.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Team Invitation (non verified)
Retry 2Retry 1Initial Attempt
5.29% (10) 10 / 189 runs
failed over last 7 days
90.48% (171) 171 / 189 runs
flaked over last 7 days
Team Invitation (verified)
Retry 1Initial Attempt
0.53% (1) 1 / 189 run
failed over last 7 days
91.01% (172) 172 / 189 runs
flaked over last 7 days

📄   apps/web/playwright/settings-admin.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Settings/admin A/B tests should point to the /future/settings/admin page
Retry 1Initial Attempt
5.79% (11) 11 / 190 runs
failed over last 7 days
7.37% (14) 14 / 190 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests user -- legacy enabling recurring event comes with default options
Retry 1Initial Attempt
2.69% (5) 5 / 186 runs
failed over last 7 days
11.29% (21) 21 / 186 runs
flaked over last 7 days

📄   apps/web/playwright/oauth-provider.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
OAuth Provider should create valid access toke & refresh token for team
Retry 1Initial Attempt
1.48% (3) 3 / 203 runs
failed over last 7 days
26.11% (53) 53 / 203 runs
flaked over last 7 days

📄   apps/web/playwright/locale.e2e.ts • 13 Flakes

Top 1 Common Error Messages

null

13 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
unauthorized user sees correct translations (de) should use correct translations and html attributes
Retry 1Initial Attempt
-30.73% (-59) -59 / 192 runs
failed over last 7 days
32.29% (62) 62 / 192 runs
flaked over last 7 days
unauthorized user sees correct translations (ar) should use correct translations and html attributes
Retry 1Initial Attempt
-32.80% (-62) -62 / 189 runs
failed over last 7 days
32.80% (62) 62 / 189 runs
flaked over last 7 days
unauthorized user sees correct translations (zh) should use correct translations and html attributes
Retry 1Initial Attempt
-32.80% (-62) -62 / 189 runs
failed over last 7 days
32.80% (62) 62 / 189 runs
flaked over last 7 days
unauthorized user sees correct translations (zh-CN) should use correct translations and html attributes
Retry 1Initial Attempt
-32.80% (-62) -62 / 189 runs
failed over last 7 days
32.80% (62) 62 / 189 runs
flaked over last 7 days
unauthorized user sees correct translations (zh-TW) should use correct translations and html attributes
Retry 1Initial Attempt
-32.80% (-62) -62 / 189 runs
failed over last 7 days
32.80% (62) 62 / 189 runs
flaked over last 7 days
unauthorized user sees correct translations (pt) should use correct translations and html attributes
Retry 1Initial Attempt
-32.80% (-62) -62 / 189 runs
failed over last 7 days
32.80% (62) 62 / 189 runs
flaked over last 7 days
unauthorized user sees correct translations (pt-br) should use correct translations and html attributes
Retry 1Initial Attempt
-32.28% (-61) -61 / 189 runs
failed over last 7 days
32.80% (62) 62 / 189 runs
flaked over last 7 days
unauthorized user sees correct translations (es-419) should use correct translations and html attributes
Retry 1Initial Attempt
-32.98% (-62) -62 / 188 runs
failed over last 7 days
32.98% (62) 62 / 188 runs
flaked over last 7 days
authorized user sees correct translations (de) should return correct translations and html attributes
Retry 1Initial Attempt
-32.98% (-62) -62 / 188 runs
failed over last 7 days
32.98% (62) 62 / 188 runs
flaked over last 7 days
authorized user sees correct translations (pt-br) should return correct translations and html attributes
Retry 1Initial Attempt
-32.45% (-61) -61 / 188 runs
failed over last 7 days
32.98% (62) 62 / 188 runs
flaked over last 7 days
authorized user sees correct translations (ar) should return correct translations and html attributes
Retry 1Initial Attempt
-33.16% (-62) -62 / 187 runs
failed over last 7 days
33.16% (62) 62 / 187 runs
flaked over last 7 days
authorized user sees changed translations (de->ar) should return correct translations and html attributes
Retry 1Initial Attempt
-6.42% (-12) -12 / 187 runs
failed over last 7 days
21.39% (40) 40 / 187 runs
flaked over last 7 days
authorized user sees changed translations (de->pt-BR) [locale1] should return correct translations and html attributes
Retry 1Initial Attempt
-10.69% (-17) -17 / 159 runs
failed over last 7 days
18.24% (29) 29 / 159 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization Invitation (verified)
Retry 1Initial Attempt
0.50% (1) 1 / 200 run
failed over last 7 days
13% (26) 26 / 200 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-creation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization should be able to create an organization and complete onboarding
Retry 1Initial Attempt
31.03% (63) 63 / 203 runs
failed over last 7 days
51.72% (105) 105 / 203 runs
flaked over last 7 days

📄   apps/web/playwright/change-username.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Change username on settings User can change username to include periods(or dots)
Retry 1Initial Attempt
0% (0) 0 / 193 runs
failed over last 7 days
4.15% (8) 8 / 193 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 4 Flakes

Top 1 Common Error Messages

null

4 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
1.02% (2) 2 / 196 runs
failed over last 7 days
62.24% (122) 122 / 196 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
0% (0) 0 / 195 runs
failed over last 7 days
81.54% (159) 159 / 195 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 2Retry 1Initial Attempt
6.12% (12) 12 / 196 runs
failed over last 7 days
89.80% (176) 176 / 196 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
0.51% (1) 1 / 195 run
failed over last 7 days
50.26% (98) 98 / 195 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Preview Preview - embed-core should load
Retry 1Initial Attempt
0% (0) 0 / 191 runs
failed over last 7 days
22.51% (43) 43 / 191 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1Initial Attempt
0% (0) 0 / 192 runs
failed over last 7 days
39.06% (75) 75 / 192 runs
flaked over last 7 days

View Detailed Build Results


@emrysal emrysal requested review from a team and removed request for a team December 11, 2023 16:45
Copy link
Contributor

github-actions bot commented Dec 11, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@CarinaWolli CarinaWolli enabled auto-merge (squash) December 12, 2023 21:00
@CarinaWolli CarinaWolli merged commit 2799ddf into main Dec 13, 2023
40 of 41 checks passed
@CarinaWolli CarinaWolli deleted the chore/handle-email-already-used branch December 13, 2023 02:24
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants