Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mandatory email reminder for attendees with @gmail.com #12747

Merged
merged 14 commits into from
Dec 13, 2023

Conversation

CarinaWolli
Copy link
Member

What does this PR do?

Changes from: #12647

By: Chiranjeev-droid

Fixes #10247

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Tests (Unit/Integration/E2E or any other test)
  • This change requires a documentation update

Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 2:16am
dev ❌ Failed (Inspect) Dec 13, 2023 2:16am
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2023 2:16am
cal ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2023 2:16am
cal-demo ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2023 2:16am
qa ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2023 2:16am
ui ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2023 2:16am

@github-actions github-actions bot added calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar Low priority Created by Linear-GitHub Sync osshack Submission for 2023 OSShack workflows area: workflows, automations ✨ feature New feature or request 🧹 Improvements Improvements to existing features. Mostly UX/UI ❗️ migrations contains migration files and removed ✨ feature New feature or request 🧹 Improvements Improvements to existing features. Mostly UX/UI Low priority Created by Linear-GitHub Sync workflows area: workflows, automations calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar osshack Submission for 2023 OSShack labels Dec 12, 2023
Copy link
Contributor

github-actions bot commented Dec 12, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@zomars zomars added the core area: core, team members only label Dec 12, 2023
Copy link

deploysentinel bot commented Dec 12, 2023

Current Playwright Test Results Summary

✅ 364 Passing - ⚠️ 9 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 12/13/2023 02:22:06am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 8978c74

Started: 12/13/2023 02:13:18am UTC

⚠️ Flakes

📄   apps/web/playwright/oauth-provider.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
OAuth Provider should create valid access toke & refresh token for team
Retry 1Initial Attempt
1.48% (3) 3 / 203 runs
failed over last 7 days
26.11% (53) 53 / 203 runs
flaked over last 7 days

📄   apps/web/playwright/reschedule.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Reschedule Tests Should do a reschedule from user owner
Retry 1Initial Attempt
0% (0) 0 / 191 runs
failed over last 7 days
10.47% (20) 20 / 191 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-creation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization should be able to create an organization and complete onboarding
Retry 2Retry 1Initial Attempt
31.03% (63) 63 / 203 runs
failed over last 7 days
51.72% (105) 105 / 203 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization Invitation (non verified)
Retry 1Initial Attempt
20% (40) 40 / 200 runs
failed over last 7 days
16% (32) 32 / 200 runs
flaked over last 7 days

📄   apps/web/playwright/team/team-invitation.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Team Invitation (non verified)
Retry 1Initial Attempt
5.29% (10) 10 / 189 runs
failed over last 7 days
90.48% (171) 171 / 189 runs
flaked over last 7 days
Team Invitation (verified)
Retry 1Initial Attempt
0.53% (1) 1 / 189 run
failed over last 7 days
91.01% (172) 172 / 189 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
6.12% (12) 12 / 196 runs
failed over last 7 days
89.80% (176) 176 / 196 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
0% (0) 0 / 195 runs
failed over last 7 days
81.54% (159) 159 / 195 runs
flaked over last 7 days

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
FORM_SUBMITTED on submitting team form, triggers team webhook
Retry 2Retry 1Initial Attempt
1.56% (3) 3 / 192 runs
failed over last 7 days
15.63% (30) 30 / 192 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Contributor

github-actions bot commented Dec 12, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@CarinaWolli
Copy link
Member Author

@Udit-takkar could you review this for me? 🙏 Changes are all coming from #12647 (expect the latest commit with some small fixes Link to Commt)

I already reviewed and it was good to go from my side

Udit-takkar
Udit-takkar previously approved these changes Dec 12, 2023
Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM. left some comments

Copy link
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved on behalf of @Udit-takkar

@CarinaWolli CarinaWolli merged commit 3164cd4 into main Dec 13, 2023
40 of 41 checks passed
@CarinaWolli CarinaWolli deleted the feat/mandatory-email-reminder branch December 13, 2023 02:23
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Dec 21, 2023
…12747)

Co-authored-by: Chiranjeev Vishnoi <somu209e@gmail.com>
Co-authored-by: CarinaWolli <wollencarina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only ❗️ migrations contains migration files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-2204] RFC: mandatory email reminder for attendees with @gmail.com
5 participants