-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mandatory email reminder for attendees with @gmail.com #12747
Conversation
…dees with gmail account
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
Current Playwright Test Results Summary✅ 364 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 12/13/2023 02:22:06am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 8978c74 Started: 12/13/2023 02:13:18am UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
OAuth Provider should create valid access toke & refresh token for team
Retry 1 • Initial Attempt |
1.48% (3)3 / 203 runsfailed over last 7 days |
26.11% (53)53 / 203 runsflaked over last 7 days |
📄 apps/web/playwright/reschedule.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Reschedule Tests Should do a reschedule from user owner
Retry 1 • Initial Attempt |
0% (0)0 / 191 runsfailed over last 7 days |
10.47% (20)20 / 191 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-creation.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Organization should be able to create an organization and complete onboarding
Retry 2 • Retry 1 • Initial Attempt |
31.03% (63)63 / 203 runsfailed over last 7 days |
51.72% (105)105 / 203 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Organization Invitation (non verified)
Retry 1 • Initial Attempt |
20% (40)40 / 200 runsfailed over last 7 days |
16% (32)32 / 200 runsflaked over last 7 days |
📄 apps/web/playwright/team/team-invitation.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
2 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Team Invitation (non verified)
Retry 1 • Initial Attempt |
5.29% (10)10 / 189 runsfailed over last 7 days |
90.48% (171)171 / 189 runsflaked over last 7 days |
Team Invitation (verified)
Retry 1 • Initial Attempt |
0.53% (1)1 / 189 runfailed over last 7 days |
91.01% (172)172 / 189 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
2 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
6.12% (12)12 / 196 runsfailed over last 7 days |
89.80% (176)176 / 196 runsflaked over last 7 days |
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
0% (0)0 / 195 runsfailed over last 7 days |
81.54% (159)159 / 195 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
FORM_SUBMITTED on submitting team form, triggers team webhook
Retry 2 • Retry 1 • Initial Attempt |
1.56% (3)3 / 192 runsfailed over last 7 days |
15.63% (30)30 / 192 runsflaked over last 7 days |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
@Udit-takkar could you review this for me? 🙏 Changes are all coming from #12647 (expect the latest commit with some small fixes Link to Commt) I already reviewed and it was good to go from my side |
packages/features/ee/workflows/lib/reminders/emailReminderManager.ts
Outdated
Show resolved
Hide resolved
packages/features/ee/workflows/lib/reminders/emailReminderManager.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM. left some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved on behalf of @Udit-takkar
…12747) Co-authored-by: Chiranjeev Vishnoi <somu209e@gmail.com> Co-authored-by: CarinaWolli <wollencarina@gmail.com>
What does this PR do?
Changes from: #12647
By: Chiranjeev-droid
Fixes #10247
Type of change