chore: removed org_team_names_example_1 #12759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
github-actions
bot
added
Low priority
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
PeerRich
commented
Dec 13, 2023
| @@ -110,7 +110,7 @@ export const AddNewTeamsForm = () => { | |||
| onChange={(e) => handleInputChange(index, e)} | |||
| addOnClassname="bg-transparent p-0 border-l-0" | |||
| className={index > 0 ? "mb-2" : ""} | |||
| placeholder={t(`org_team_names_example_${index + 1}`) || t("org_team_names_example_1")} | |||
| placeholder={t(`org_team_names_example_${index + 1}`)} | |||
There was a problem hiding this comment.
not sure what the || was trying to achieve so i removed it @Udit-takkar
Current Playwright Test Results Summary✅ 363 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 12/13/2023 02:02:16am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 012700f Started: 12/13/2023 01:54:33am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Select Question and Phone Question Select required and select required
Retry 1 • Initial Attempt |
0% (0)0 / 181 runsfailed over last 7 days |
1.66% (3)3 / 181 runsflaked over last 7 days |
📄 apps/web/playwright/change-theme.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Change Theme Test change theme to light
Retry 1 • Initial Attempt |
0% (0)0 / 188 runsfailed over last 7 days |
1.06% (2)2 / 188 runsflaked over last 7 days |
📄 apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and Long text Question Phone and Long text required
Retry 1 • Initial Attempt |
0.53% (1)1 / 188 runfailed over last 7 days |
2.66% (5)5 / 188 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 4 Flakes
Top 1 Common Error Messages
|
|
4 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
1.05% (2)2 / 190 runsfailed over last 7 days |
62.63% (119)119 / 190 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
0.53% (1)1 / 189 runfailed over last 7 days |
50.79% (96)96 / 189 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt |
6.32% (12)12 / 190 runsfailed over last 7 days |
89.47% (170)170 / 190 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
0% (0)0 / 189 runsfailed over last 7 days |
82.01% (155)155 / 189 runsflaked over last 7 days |
📄 apps/web/playwright/oauth-provider.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
OAuth Provider should create valid access toke & refresh token for team
Retry 1 • Initial Attempt |
1.52% (3)3 / 197 runsfailed over last 7 days |
23.86% (47)47 / 197 runsflaked over last 7 days |
📄 apps/web/playwright/team/team-invitation.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Team Invitation (non verified)
Retry 2 • Retry 1 • Initial Attempt |
5.46% (10)10 / 183 runsfailed over last 7 days |
90.16% (165)165 / 183 runsflaked over last 7 days |
|
Team Invitation (verified)
Retry 1 • Initial Attempt |
0.55% (1)1 / 183 runfailed over last 7 days |
90.71% (166)166 / 183 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
0% (0)0 / 186 runsfailed over last 7 days |
38.71% (72)72 / 186 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-creation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Organization should be able to create an organization and complete onboarding
Retry 2 • Retry 1 • Initial Attempt |
31.98% (63)63 / 197 runsfailed over last 7 days |
52.28% (103)103 / 197 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Organization Invitation (verified)
Retry 1 • Initial Attempt |
0.52% (1)1 / 194 runfailed over last 7 days |
11.86% (23)23 / 194 runsflaked over last 7 days |
Udit-takkar
approved these changes
Dec 13, 2023
Udit-takkar
deleted the
12729-cal-2788-string-of-text-shows-on-the-org-onboarding-for-creating-teams
branch
hbjORbj
pushed a commit
to codemod-com/cal.com-demo
that referenced
this pull request
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.