chore: [app-router-migration-11] Migrate workflow page group #12777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DmytroHryshyn is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
DmytroHryshyn
changed the title
DmytroHryshyn
force-pushed
the
chore/migrate-worflows-page
branch
2 times, most recently
from
2695b32
to
1d6ad29
Compare
hbjORbj
force-pushed
the
chore/migrate-worflows-page
branch
2 times, most recently
from
3a117ec
to
87d4b85
Compare
DmytroHryshyn
force-pushed
the
chore/migrate-worflows-page
branch
2 times, most recently
from
d8247a0
to
910a08a
Compare
DmytroHryshyn
force-pushed
the
chore/migrate-worflows-page
branch
2 times, most recently
from
1c43109
to
ebae929
Compare
DmytroHryshyn
changed the title
hbjORbj
force-pushed
the
chore/migrate-worflows-page
branch
from
ebae929
to
276d740
Compare
zomars
previously approved these changes
Jan 9, 2024
keithwillcode
requested changes
Jan 10, 2024
| import { WithLayout } from "app/layoutHOC"; | ||
|
|
||
| import { getLayout } from "@calcom/features/MainLayoutAppDir"; | ||
| import LgeacyPage from "@calcom/features/ee/workflows/pages/index"; |
There was a problem hiding this comment.
Suggested change
| import LgeacyPage from "@calcom/features/ee/workflows/pages/index"; | |
| import LegacyPage from "@calcom/features/ee/workflows/pages/index"; |
| (t) => t("workflows_to_automate_notifications") | ||
| ); | ||
|
|
||
| export default WithLayout({ getLayout, Page: LgeacyPage })<"P">; |
There was a problem hiding this comment.
Suggested change
| export default WithLayout({ getLayout, Page: LgeacyPage })<"P">; | |
| export default WithLayout({ getLayout, Page: LegacyPage })<"P">; |
| async function getProps(context: GetServerSidePropsContext) { | ||
| const safeParams = querySchema.safeParse(context.params); | ||
|
|
||
| console.log("Built workflow page:", safeParams); |
There was a problem hiding this comment.
Do we need this log?
There was a problem hiding this comment.
We copied it from the legacy page as it is. Please let us know if it can be deleted.
hbjORbj
force-pushed
the
chore/migrate-worflows-page
branch
from
7c2f67d
to
f17519c
Compare
|
@keithwillcode Addressed your comments + Rebased on latest main. |
keithwillcode
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrates
workflows/path*page groupRequirement/Documentation
Type of change
How should this be tested?
Mandatory Tasks