Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: country code [Testing] #12807

Merged
merged 5 commits into from
Dec 19, 2023
Merged

fix: country code [Testing] #12807

merged 5 commits into from
Dec 19, 2023

Conversation

Udit-takkar
Copy link
Contributor

@Udit-takkar Udit-takkar commented Dec 15, 2023

Copy link

vercel bot commented Dec 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 8:03am
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 8:03am
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2023 8:03am
cal ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2023 8:03am
cal-demo ⬜️ Ignored (Inspect) Dec 19, 2023 8:03am
qa ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2023 8:03am
ui ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2023 8:03am

Copy link
Contributor

github-actions bot commented Dec 15, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@zomars zomars added the core area: core, team members only label Dec 15, 2023
Copy link
Contributor

github-actions bot commented Dec 15, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Dec 15, 2023

Current Playwright Test Results Summary

✅ 343 Passing - ❌ 1 Failing - ⚠️ 7 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 12/18/2023 12:24:26pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: bcf1afb

Started: 12/18/2023 12:15:06pm UTC

❌ Failures

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 2Retry 1Initial Attempt
Error: Test timeout of 60000ms exceeded.
Test timeout of 60000ms exceeded.
12.69% (33) 33 / 260 runs
failed over last 7 days
81.92% (213) 213 / 260 runs
flaked over last 7 days

⚠️ Flakes

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 3 Flakes

Top 1 Common Error Messages

null

3 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
1.15% (3) 3 / 260 runs
failed over last 7 days
60.38% (157) 157 / 260 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
0.38% (1) 1 / 260 run
failed over last 7 days
49.23% (128) 128 / 260 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
0.38% (1) 1 / 260 run
failed over last 7 days
83.46% (217) 217 / 260 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-creation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization should be able to create an organization and complete onboarding
Retry 1Initial Attempt
12.64% (33) 33 / 261 runs
failed over last 7 days
52.11% (136) 136 / 261 runs
flaked over last 7 days

📄   apps/web/playwright/team/team-invitation.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Team Invitation (verified)
Retry 1Initial Attempt
0% (0) 0 / 254 runs
failed over last 7 days
95.28% (242) 242 / 254 runs
flaked over last 7 days
Team Invitation (non verified)
Retry 1Initial Attempt
3.94% (10) 10 / 254 runs
failed over last 7 days
93.31% (237) 237 / 254 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1Initial Attempt
0.39% (1) 1 / 257 run
failed over last 7 days
43.58% (112) 112 / 257 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@emrysal emrysal enabled auto-merge (squash) December 19, 2023 07:54
@Udit-takkar
Copy link
Contributor Author

Udit-takkar commented Dec 19, 2023

Screenshot 2023-12-19 at 1 26 19 PM

@emrysal I don't get country code in the response. were you able to test it after enabling this https://threads.com/thread/34538151691/34553895436?s=cutsX49CgqKKNEqfWRL16S ?

@emrysal emrysal merged commit b6279f4 into main Dec 19, 2023
22 of 24 checks passed
@emrysal emrysal deleted the fix/country-code branch December 19, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants