Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Moved e2e suite to run on pushes to main #12819

Merged
merged 7 commits into from
Dec 18, 2023
Merged

Conversation

keithwillcode
Copy link
Contributor

@keithwillcode keithwillcode commented Dec 15, 2023

What does this PR do?

Instead of running the full e2e test suite on every PR update, we are now going to run it on pushes to main. This will reduce PR wait times and costs. A known side effect is that we can end up with broken e2e tests in main but we will ensure this suite is passing before new releases go out. This PR precedes other changes to the release process to run this e2e job.

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  • Manually trigger this to ensure all of the E2E tests run correctly

Copy link

vercel bot commented Dec 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2023 8:07pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2023 8:07pm
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Dec 15, 2023 8:07pm
cal ⬜️ Ignored (Inspect) Visit Preview Dec 15, 2023 8:07pm
cal-demo ⬜️ Ignored (Inspect) Visit Preview Dec 15, 2023 8:07pm
qa ⬜️ Ignored (Inspect) Visit Preview Dec 15, 2023 8:07pm
ui ⬜️ Ignored (Inspect) Visit Preview Dec 15, 2023 8:07pm

Copy link
Contributor

github-actions bot commented Dec 15, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode requested a review from a team December 15, 2023 19:34
@keithwillcode keithwillcode self-assigned this Dec 15, 2023
@keithwillcode keithwillcode marked this pull request as ready for review December 15, 2023 19:34
@keithwillcode keithwillcode marked this pull request as draft December 15, 2023 19:39
@keithwillcode keithwillcode marked this pull request as ready for review December 15, 2023 19:46
Copy link

deploysentinel bot commented Dec 15, 2023

Current Playwright Test Results Summary

✅ 344 Passing - ⚠️ 6 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 12/15/2023 07:58:26pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: e9e0e0a

Started: 12/15/2023 07:48:32pm UTC

⚠️ Flakes

📄   apps/web/playwright/team/team-invitation.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Team Invitation (non verified)
Retry 2Retry 1Initial Attempt
4.46% (12) 12 / 269 runs
failed over last 7 days
92.19% (248) 248 / 269 runs
flaked over last 7 days
Team Invitation (verified)
Retry 1Initial Attempt
0.37% (1) 1 / 269 run
failed over last 7 days
94.05% (253) 253 / 269 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-creation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization should be able to create an organization and complete onboarding
Retry 1Initial Attempt
21.74% (60) 60 / 276 runs
failed over last 7 days
46.74% (129) 129 / 276 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
8.39% (23) 23 / 274 runs
failed over last 7 days
86.50% (237) 237 / 274 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
0% (0) 0 / 273 runs
failed over last 7 days
81.68% (223) 223 / 273 runs
flaked over last 7 days

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
FORM_SUBMITTED on submitting team form, triggers team webhook
Retry 1Initial Attempt
1.84% (5) 5 / 272 runs
failed over last 7 days
14.71% (40) 40 / 272 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emrysal emrysal merged commit 09f8044 into main Dec 18, 2023
51 checks passed
@emrysal emrysal deleted the chore/move-e2e-to-main branch December 18, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin core area: core, team members only devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants