Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple bookings created on verify-email #12864

Merged

Conversation

SomayChauhan
Copy link
Member

What does this PR do?

Fixes #12860

Before

Screencast.from.19-12-23.11.53.48.AM.IST.webm

After

Screencast.from.19-12-23.11.56.03.AM.IST.webm

Copy link

vercel bot commented Dec 19, 2023

@SomayChauhan is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the 🐛 bug Something isn't working label Dec 19, 2023
Copy link
Contributor

github-actions bot commented Dec 19, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@@ -25,6 +25,7 @@ export const VerifyCodeDialog = ({
const [isLoading, setIsLoading] = useState(false);
const [error, setError] = useState("");
const [value, setValue] = useState("");
const [hasVerified, setHasVerified] = useState(false);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reason for multiple bookings was that verifyCode was being called multipe times, so create a flag and setting it to true once the function has been visited

Copy link
Contributor

github-actions bot commented Dec 19, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@Ryukemeister Ryukemeister changed the title fix: multiple boolkings created on verify-email fix: multiple bookings created on verify-email Dec 19, 2023
Copy link
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works, nice fix 👏🏻

@CarinaWolli CarinaWolli merged commit 6ce2d98 into calcom:main Dec 19, 2023
14 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-2828] Multiple events are created
3 participants