Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: managed event type string #12891

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

ritiksharmarj
Copy link
Contributor

What does this PR do?

Fixes #12883
Fix the text "count_members" from the team's managed event types. We don't have "count_members" or "count_members_one" or "count_members_other" in the locales to set count.

Demo

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Go to event types page
  • Select managed event in the team event list or create new team event and select managed event
  • Check "Assignment" tab

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

Copy link

vercel bot commented Dec 20, 2023

@ritiksharmarj is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Dec 20, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link
Contributor

github-actions bot commented Dec 20, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Updated the translation string with the right value.
Bring back formMethods variable.
@emrysal emrysal self-requested a review December 20, 2023 14:01
@emrysal emrysal enabled auto-merge (squash) December 20, 2023 14:01
@emrysal
Copy link
Contributor

emrysal commented Dec 20, 2023

I changed the PR to keep the feature with the right translation string; it wasn't count_member but number_member (which has incorrect naming, but here we are)

Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes issue :)

@emrysal emrysal merged commit 2693b30 into calcom:main Dec 20, 2023
14 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-2831] Managed Event Types has a String showing in Product
2 participants