fix: Links on avatar for org events #12892
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
hariombalhara
force-pushed
the
12-20-fix_Links_on_avatar_for_org_events
branch
from
7b041bc
to
61b6bdc
Compare
|
Would it make sense to write component test(UserAvatarGroupWithOrg.test.tsx) for this bug? |
| @@ -93,7 +93,7 @@ function handleDomainCreationError(error: { code?: string | null; domain?: strin | |||
| return true; | |||
| } | |||
|
|
|||
| const errorMessage = `Failed to take action for domain: ${error.domain}`; | |||
| const errorMessage = `Failed to create domain on Vercel: ${error.domain}`; | |||
There was a problem hiding this comment.
Improved the error message in the PR as I saw the error while testing and it wasn't clear enough
| image: getUserAvatarUrl(user), | ||
| alt: user.name || undefined, | ||
| title: user.name || user.username || "", | ||
| }; | ||
| }) | ||
| ); | ||
| users.unshift(); |
There was a problem hiding this comment.
I don't know why it was there, but unshift without argument doesn't do anything.
| organization: Pick<Team, "slug" | "name">; | ||
| }; | ||
|
|
||
| export function UserAvatarGroupWithOrg(props: UserAvatarProps) { | ||
| const { users, organization, ...rest } = props; | ||
| const orgBranding = useOrgBranding(); |
There was a problem hiding this comment.
useOrgBranding gives the org details for the logged in user and not the organizer being booked.
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Seventeen Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
What does this PR do?
Fixes #12890
Regression from https://github.com/calcom/cal.com/pull/12158/files#diff-b386e7d0341aaeb0cd268b7608c7ea2b5718349f844f3203fa4c422a4f5ab29dR14
Type of change
How should this be tested?
Mandatory Tasks
Checklist