Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preview link for a non-org member within a team inside an org #12911

Conversation

hariombalhara
Copy link
Member

@hariombalhara hariombalhara commented Dec 21, 2023

Copy link

vercel bot commented Dec 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2023 11:12am
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2023 11:12am
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2023 11:12am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Dec 21, 2023 11:12am
cal-demo ⬜️ Ignored (Inspect) Dec 21, 2023 11:12am
qa ⬜️ Ignored (Inspect) Visit Preview Dec 21, 2023 11:12am
ui ⬜️ Ignored (Inspect) Visit Preview Dec 21, 2023 11:12am

@hariombalhara
Copy link
Member Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link
Contributor

github-actions bot commented Dec 21, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@zomars zomars added the core area: core, team members only label Dec 21, 2023
@hariombalhara hariombalhara changed the title fix: bookerUrl for the user that isn't part of the org but appears in a team inside the org fix: preview link for a non-org member within a team inside an org Dec 21, 2023
@hariombalhara hariombalhara requested a review from a team December 21, 2023 11:08
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Seventeen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/[type] 251.24 KB 415.51 KB 118.72% (🟢 -2.22%)
/[user]/[type]/embed 251.27 KB 415.55 KB 118.73% (🟢 -2.22%)
/apps/[slug]/[...pages] 545.72 KB 709.99 KB 202.85% (🟡 +0.32%)
/availability 422.41 KB 586.69 KB 167.62% (🟡 +0.35%)
/d/[link]/[slug] 251.09 KB 415.36 KB 118.67% (🟢 -2.22%)
/event-types 543.61 KB 707.88 KB 202.25% (🟡 +0.32%)
/event-types/[type] 419.85 KB 584.12 KB 166.89% (🟡 +0.28%)
/org/[orgSlug]/[user]/[type] 251.48 KB 415.75 KB 118.79% (🟢 -2.22%)
/org/[orgSlug]/[user]/[type]/embed 251.51 KB 415.78 KB 118.79% (🟢 -2.22%)
/org/[orgSlug]/instant-meeting/team/[slug]/[type] 251.1 KB 415.37 KB 118.68% (🟢 -2.22%)
/org/[orgSlug]/team/[slug]/[type] 251.13 KB 415.4 KB 118.69% (🟢 -2.22%)
/settings/organizations/members 420.1 KB 584.37 KB 166.96% (🟡 +0.33%)
/settings/organizations/teams/other/[id]/profile 458.74 KB 623.02 KB 178.00% (🟡 +0.27%)
/settings/teams/[id]/onboard-members 155.92 KB 320.19 KB 91.48% (🟡 +0.30%)
/settings/teams/[id]/profile 459.57 KB 623.84 KB 178.24% (🟡 +0.26%)
/team/[slug]/[type] 251.1 KB 415.37 KB 118.68% (🟢 -2.22%)
/team/[slug]/[type]/embed 251.13 KB 415.4 KB 118.69% (🟢 -2.22%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@exception exception merged commit a03a1ba into main Dec 21, 2023
28 checks passed
@exception exception deleted the 12-21-fix_bookerUrl_for_the_user_that_isn_t_part_of_the_org_but_appears_in_a_team_inside_the_org branch December 21, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants