Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix NODE_OPTIONS error #13024

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

keithwillcode
Copy link
Contributor

What does this PR do?

Fixes GitHub actions errors "Can't store NODE_OPTIONS output parameter using '$GITHUB_ENV' command." This is no longer allowed by GitHub.

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  • Ensure we no longer see these errors in the GitHub actions output when the pre-release checks are run

@keithwillcode keithwillcode self-assigned this Jan 3, 2024
Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview Jan 3, 2024 11:33pm
api ✅ Ready (Inspect) Visit Preview Jan 3, 2024 11:33pm
3 Ignored Deployments
Name Status Preview Updated (UTC)
cal ⬜️ Ignored (Inspect) Jan 3, 2024 11:33pm
cal-demo ⬜️ Ignored (Inspect) Jan 3, 2024 11:33pm
ui ⬜️ Ignored (Inspect) Jan 3, 2024 11:33pm

@keithwillcode keithwillcode requested a review from a team January 3, 2024 23:33
Copy link
Contributor

github-actions bot commented Jan 3, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added admin cal-ai core area: core, team members only devops labels Jan 3, 2024
Copy link

deploysentinel bot commented Jan 3, 2024

Current Playwright Test Results Summary

✅ 338 Passing - ❌ 3 Failing - ⚠️ 17 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 01/03/2024 11:51:40pm UTC)

Run Details

Running Workflow Pre-release checks on Github Actions

Commit: de92e77

Started: 01/03/2024 11:43:05pm UTC

❌ Failures

📄   apps/web/playwright/integrations-stripe.e2e.ts • 2 Failures

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Paid booking should be able to be cancelled
Retry 1Initial Attempt
Error: Test timeout of 60000ms exceeded.
Test timeout of 60000ms exceeded.
75.86% (22) 22 / 29 runs
failed over last 7 days
0% (0) 0 / 29 runs
flaked over last 7 days
Stripe integration When event is paid and confirmed Cancelled paid booking should be refunded
Retry 1Initial Attempt
Error: page.waitForURL: Timeout 30000ms exceeded....
page.waitForURL: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for navigation until "load"
============================================================
75.86% (22) 22 / 29 runs
failed over last 7 days
0% (0) 0 / 29 runs
flaked over last 7 days

📄   apps/web/playwright/booking-limits.e2e.ts • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking limits multiple
Retry 2Retry 1Initial Attempt
Error: expect(received).toBe(expected) // Object.is equality...
expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false
85.19% (23) 23 / 27 runs
failed over last 7 days
0% (0) 0 / 27 runs
flaked over last 7 days

⚠️ Flakes

📄   apps/web/playwright/organization/organization-invitation.e2e.ts • 4 Flakes

Top 1 Common Error Messages

null

4 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization Email not matching orgAutoAcceptEmail Org Invitation
Retry 2Retry 1Initial Attempt
-2.94% (-1) -1 / 34 runs
failed over last 7 days
14.71% (5) 5 / 34 runs
flaked over last 7 days
Organization Email not matching orgAutoAcceptEmail Team invitation
Retry 2Retry 1Initial Attempt
0% (0) 0 / 34 runs
failed over last 7 days
23.53% (8) 8 / 34 runs
flaked over last 7 days
Organization Email matching orgAutoAcceptEmail and a Verified Organization Org Invitation
Retry 2Retry 1Initial Attempt
-2.94% (-1) -1 / 34 runs
failed over last 7 days
29.41% (10) 10 / 34 runs
flaked over last 7 days
Organization Email matching orgAutoAcceptEmail and a Verified Organization Team Invitation
Retry 2Retry 1Initial Attempt
11.76% (4) 4 / 34 runs
failed over last 7 days
20.59% (7) 7 / 34 runs
flaked over last 7 days

📄   apps/web/playwright/booking/longTextQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Checkbox Group Question Long Text required and Checkbox Group not required
Retry 2Retry 1Initial Attempt
0% (0) 0 / 28 runs
failed over last 7 days
3.57% (1) 1 / 28 run
flaked over last 7 days

📄   apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Multi email Question Checkbox Group required and Multi email required
Retry 1Initial Attempt
0% (0) 0 / 28 runs
failed over last 7 days
3.57% (1) 1 / 28 run
flaked over last 7 days

📄   apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Phone required and Address not required
Retry 1Initial Attempt
0% (0) 0 / 28 runs
failed over last 7 days
3.57% (1) 1 / 28 run
flaked over last 7 days

📄   apps/web/playwright/oauth-provider.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
OAuth Provider should create valid access toke & refresh token for team
Retry 1Initial Attempt
0% (0) 0 / 1 runs
failed over last 7 days
100% (1) 1 / 1 run
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
3.13% (1) 1 / 32 run
failed over last 7 days
87.50% (28) 28 / 32 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
0% (0) 0 / 32 runs
failed over last 7 days
87.50% (28) 28 / 32 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-creation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization Admin should be able to create an organization and complete onboarding
Retry 1Initial Attempt
0% (0) 0 / 34 runs
failed over last 7 days
2.94% (1) 1 / 34 run
flaked over last 7 days

📄   apps/web/playwright/embed-code-generator.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Embed Code Generator Tests Non-Organization Event Types Page open Embed Dialog and choose Inline for First Event Type
Retry 1Initial Attempt
3.03% (1) 1 / 33 run
failed over last 7 days
12.12% (4) 4 / 33 runs
flaked over last 7 days

📄   apps/web/playwright/booking/multipleEmailQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and Number Question Multiple Email and Number not required
Retry 1Initial Attempt
0% (0) 0 / 28 runs
failed over last 7 days
3.57% (1) 1 / 28 run
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests user -- legacy has at least 2 events
Retry 1Initial Attempt
0% (0) 0 / 31 runs
failed over last 7 days
6.45% (2) 2 / 31 runs
flaked over last 7 days

📄   apps/web/playwright/team/team-invitation.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Team Invitation (non verified)
Retry 2Retry 1Initial Attempt
0% (0) 0 / 33 runs
failed over last 7 days
12.12% (4) 4 / 33 runs
flaked over last 7 days
Team Invitation (verified)
Retry 1Initial Attempt
0% (0) 0 / 33 runs
failed over last 7 days
3.03% (1) 1 / 33 run
flaked over last 7 days

📄   apps/web/playwright/signup.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Signup Flow Test Email verification sent if enabled
Retry 1Initial Attempt
0% (0) 0 / 33 runs
failed over last 7 days
3.03% (1) 1 / 33 run
flaked over last 7 days

View Detailed Build Results


Copy link
Contributor

github-actions bot commented Jan 3, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Thirty-three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/[type] 259.02 KB 423.29 KB 120.94% (🟢 -0.24%)
/[user]/[type]/embed 259.05 KB 423.33 KB 120.95% (🟢 -0.24%)
/apps 267.52 KB 431.8 KB 123.37% (🟢 -0.20%)
/apps/[slug]/[...pages] 544.65 KB 708.92 KB 202.55% (🟢 -0.34%)
/apps/installed/[category] 269.56 KB 433.84 KB 123.95% (🟢 -0.24%)
/availability 421.26 KB 585.54 KB 167.30% (🟢 -0.37%)
/availability/[schedule] 348.97 KB 513.25 KB 146.64% (🟢 -0.29%)
/availability/troubleshoot 270.75 KB 435.03 KB 124.29% (🟢 -0.23%)
/bookings/[status] 312.95 KB 477.23 KB 136.35% (🟢 -0.30%)
/d/[link]/[slug] 258.86 KB 423.14 KB 120.90% (🟢 -0.25%)
/event-types 542.54 KB 706.82 KB 201.95% (🟢 -0.37%)
/event-types/[type] 418.91 KB 583.19 KB 166.62% (🟢 -0.37%)
/getting-started/[[...step]] 401.74 KB 566.02 KB 161.72% (🟢 -0.34%)
/org/[orgSlug]/[user]/[type] 259.26 KB 423.53 KB 121.01% (🟢 -0.24%)
/org/[orgSlug]/[user]/[type]/embed 259.28 KB 423.56 KB 121.02% (🟢 -0.25%)
/org/[orgSlug]/instant-meeting/team/[slug]/[type] 258.87 KB 423.15 KB 120.90% (🟢 -0.24%)
/org/[orgSlug]/team/[slug]/[type] 258.9 KB 423.18 KB 120.91% (🟢 -0.24%)
/settings/admin/apps 264.88 KB 429.16 KB 122.62% (🟢 -0.25%)
/settings/admin/apps/[category] 264.86 KB 429.14 KB 122.61% (🟢 -0.24%)
/settings/my-account/appearance 275.2 KB 439.48 KB 125.57% (🟢 -0.35%)
/settings/my-account/calendars 263.53 KB 427.81 KB 122.23% (🟢 -0.14%)
/settings/my-account/general 340.04 KB 504.32 KB 144.09% (🟢 -0.33%)
/settings/organizations/appearance 275.28 KB 439.56 KB 125.59% (🟢 -0.34%)
/settings/organizations/teams/other/[id]/appearance 264.34 KB 428.61 KB 122.46% (🟢 -0.34%)
/settings/organizations/teams/other/[id]/members 258.84 KB 423.12 KB 120.89% (🟢 -0.32%)
/settings/security/impersonation 257.01 KB 421.29 KB 120.37% (🟢 -0.33%)
/settings/security/password 265.76 KB 430.04 KB 122.87% (🟢 -0.34%)
/settings/security/two-factor-auth 260.84 KB 425.12 KB 121.46% (🟢 -0.23%)
/settings/teams/[id]/appearance 264.32 KB 428.6 KB 122.46% (🟢 -0.34%)
/settings/teams/[id]/members 377.54 KB 541.82 KB 154.80% (🟢 -0.33%)
/team/[slug]/[type] 258.87 KB 423.15 KB 120.90% (🟢 -0.24%)
/team/[slug]/[type]/embed 258.9 KB 423.18 KB 120.91% (🟢 -0.25%)
/workflows 283.46 KB 447.74 KB 127.93% (🟢 -0.33%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@keithwillcode keithwillcode added the Low priority Created by Linear-GitHub Sync label Jan 4, 2024
@keithwillcode keithwillcode merged commit 4c4fc9e into main Jan 4, 2024
46 of 51 checks passed
@keithwillcode keithwillcode deleted the chore/fix-node-options-error branch January 4, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin cal-ai core area: core, team members only devops Low priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants