Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [app-router-migration 13] Migrate reschedule page group #13030

Merged

Conversation

DmytroHryshyn
Copy link
Contributor

@DmytroHryshyn DmytroHryshyn commented Jan 4, 2024

What does this PR do?

Fixes # (issue)

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

Copy link

vercel bot commented Jan 4, 2024

@DmytroHryshyn is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Jan 4, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link
Contributor

github-actions bot commented Jan 4, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@DmytroHryshyn DmytroHryshyn force-pushed the 12-22-chore/migrate-reschedule-page branch from a48ce31 to f3fb1f4 Compare January 5, 2024 11:11
@DmytroHryshyn DmytroHryshyn marked this pull request as ready for review January 5, 2024 11:29
@PeerRich PeerRich added the High priority Created by Linear-GitHub Sync label Jan 5, 2024
@PeerRich PeerRich requested a review from zomars January 8, 2024 13:12
@keithwillcode keithwillcode added this to the v3.7 milestone Jan 10, 2024
@keithwillcode keithwillcode self-requested a review January 10, 2024 23:40
Copy link
Contributor

@keithwillcode keithwillcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter is failing

@hbjORbj hbjORbj force-pushed the 12-22-chore/migrate-reschedule-page branch from 15da8b7 to db76e30 Compare January 11, 2024 09:11
@hbjORbj
Copy link
Contributor

hbjORbj commented Jan 11, 2024

@keithwillcode Fixed the lint error and type error + Rebasing on latest main. Our bad for not checking the failures more carefully.

@keithwillcode keithwillcode merged commit 070ec32 into calcom:main Jan 11, 2024
30 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants