Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [app-router-migration 15] migrate bookings/* page group #13038

Merged
merged 4 commits into from
Jan 11, 2024
Merged

chore: [app-router-migration 15] migrate bookings/* page group #13038

merged 4 commits into from
Jan 11, 2024

Conversation

DmytroHryshyn
Copy link
Contributor

@DmytroHryshyn DmytroHryshyn commented Jan 4, 2024 •
edited by keithwillcode

What does this PR do?

migrate bookings/* page group

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel Vercel
Copy link

vercel bot commented Jan 4, 2024

@DmytroHryshyn is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024 •
edited

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@DmytroHryshyn DmytroHryshyn changed the title Chore/migrate bookings page chore [app-router-migration 15]: migrate bookings/* page group Jan 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024 •
edited

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@DmytroHryshyn DmytroHryshyn force-pushed the chore/migrate-bookings-page branch 2 times, most recently from 5d81a4e to 258eace Compare January 5, 2024 12:00
@DmytroHryshyn DmytroHryshyn marked this pull request as ready for review January 5, 2024 12:02
@PeerRich PeerRich added the High priority Created by Linear-GitHub Sync label Jan 5, 2024
@DmytroHryshyn DmytroHryshyn changed the title chore [app-router-migration 15]: migrate bookings/* page group chore: [app-router-migration 15] migrate bookings/* page group Jan 8, 2024
@PeerRich PeerRich requested a review from zomars January 8, 2024 12:55
@hbjORbj hbjORbj force-pushed the chore/migrate-bookings-page branch 2 times, most recently from 47e5d01 to 7b894ce Compare January 9, 2024 13:53
@keithwillcode keithwillcode added this to the v3.7 milestone Jan 10, 2024
@hbjORbj
Copy link
Contributor

hbjORbj commented Jan 11, 2024

@keithwillcode This PR is ready as well :D

@keithwillcode keithwillcode self-requested a review January 11, 2024 12:41
@keithwillcode keithwillcode merged commit 684575d into calcom:main Jan 11, 2024
30 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithwillcode keithwillcode keithwillcode approved these changes

@zomars zomars Awaiting requested review from zomars

Assignees
No one assigned
Labels
High priority Created by Linear-GitHub Sync
Projects
None yet
Milestone
v3.7
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DmytroHryshyn @hbjORbj @keithwillcode @PeerRich