Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [app-router-migration 23] Migrate the "enterprise" page #13044

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

grzpab
Copy link
Contributor

@grzpab grzpab commented Jan 4, 2024

What does this PR do?

This PR migrates the /enterprise page to the app router, under /future/enterprise.

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

Copy link

vercel bot commented Jan 4, 2024

@grzpab is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Jan 4, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@grzpab grzpab changed the title chore: migrate the /enterprise page to the app router chore: [app-router-migration 19] Migrate the "enterprise" page Jan 4, 2024
@grzpab grzpab changed the title chore: [app-router-migration 19] Migrate the "enterprise" page chore: [app-router-migration 23] Migrate the "enterprise" page Jan 4, 2024
Copy link
Contributor

github-actions bot commented Jan 4, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/enterprise/component 239.65 KB 404.4 KB 115.54%

Nineteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps 269.21 KB 433.96 KB 123.99% (🟢 -0.24%)
/apps/installed/[category] 270.51 KB 435.26 KB 124.36% (🟢 -0.37%)
/availability 423.35 KB 588.1 KB 168.03% (🟢 -0.35%)
/availability/[schedule] 350.79 KB 515.54 KB 147.30% (🟢 -0.19%)
/bookings/[status] 314.78 KB 479.53 KB 137.01% (🟢 -0.20%)
/event-types 544.82 KB 709.57 KB 202.73% (🟢 -0.25%)
/event-types/[type] 420.98 KB 585.73 KB 167.35% (🟢 -0.24%)
/getting-started/[[...step]] 401.68 KB 566.43 KB 161.84% (🟢 -0.64%)
/settings/my-account/appearance 277.01 KB 441.76 KB 126.22% (🟢 -0.24%)
/settings/my-account/calendars 264.43 KB 429.18 KB 122.62% (🟢 -0.29%)
/settings/my-account/general 341.8 KB 506.55 KB 144.73% (🟢 -0.22%)
/settings/organizations/appearance 277.05 KB 441.8 KB 126.23% (🟢 -0.24%)
/settings/organizations/teams/other/[id]/appearance 266.1 KB 430.85 KB 123.10% (🟢 -0.23%)
/settings/organizations/teams/other/[id]/members 260.8 KB 425.55 KB 121.59% (🟢 -0.23%)
/settings/security/impersonation 258.78 KB 423.53 KB 121.01% (🟢 -0.23%)
/settings/security/password 267.6 KB 432.35 KB 123.53% (🟢 -0.23%)
/settings/teams/[id]/appearance 266.09 KB 430.84 KB 123.10% (🟢 -0.24%)
/settings/teams/[id]/members 379.55 KB 544.3 KB 155.51% (🟢 -0.22%)
/workflows 285.28 KB 450.03 KB 128.58% (🟢 -0.22%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@formkit/auto-animate 0.8.1...1.0.0-beta.5 None +0/-0 35.4 kB justin-schroeder

@PeerRich PeerRich added the High priority Created by Linear-GitHub Sync label Jan 8, 2024
@PeerRich PeerRich requested a review from zomars January 8, 2024 13:02
@grzpab grzpab force-pushed the gpp/enterprise branch 2 times, most recently from 1c553b5 to eff2d7b Compare January 9, 2024 13:37
@grzpab grzpab marked this pull request as ready for review January 9, 2024 13:37
@keithwillcode keithwillcode added this to the v3.7 milestone Jan 10, 2024
@keithwillcode keithwillcode self-requested a review January 11, 2024 02:56
@@ -39,7 +39,7 @@
"@calcom/tsconfig": "*",
"@calcom/ui": "*",
"@daily-co/daily-js": "^0.37.0",
"@formkit/auto-animate": "^0.8.1",
"@formkit/auto-animate": "1.0.0-beta.5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we intentionally using a beta here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PeerRich PeerRich removed the request for review from zomars January 11, 2024 12:54
@PeerRich PeerRich enabled auto-merge (squash) January 11, 2024 12:54
@PeerRich PeerRich merged commit cd9d16b into calcom:main Jan 11, 2024
30 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants