Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [app-router-migration 20] Migrate /settings/security/* pages #13046

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Jan 4, 2024

What does this PR do?

  • This PR migrates the /settings/security/* page group to the app directory (which runs under the App Router).
  • The migrated page exists under /future and is accessible at all times.

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Tests (Unit/Integration/E2E or any other test)
  • This change requires a documentation update

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@hbjORbj hbjORbj marked this pull request as draft January 4, 2024 18:54
Copy link

vercel bot commented Jan 4, 2024

@hbjORbj is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Jan 4, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link
Contributor

github-actions bot commented Jan 4, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@hbjORbj hbjORbj marked this pull request as ready for review January 5, 2024 14:10
@hbjORbj hbjORbj changed the title chore: [app-router-migration 20] Migrate "/settings/security/*" pages chore: [app-router-migration 20] Migrate /settings/security/* pages Jan 5, 2024
@PeerRich PeerRich added the High priority Created by Linear-GitHub Sync label Jan 5, 2024
@PeerRich PeerRich requested a review from zomars January 8, 2024 13:11
@keithwillcode keithwillcode added this to the v3.7 milestone Jan 10, 2024
@PeerRich PeerRich merged commit 0df6777 into calcom:main Jan 11, 2024
30 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants