Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bundle analysis commenting #13116

Merged
merged 5 commits into from
Jan 10, 2024
Merged

fix: Bundle analysis commenting #13116

merged 5 commits into from
Jan 10, 2024

Conversation

keithwillcode
Copy link
Contributor

@keithwillcode keithwillcode commented Jan 9, 2024

What does this PR do?

Fixes GITHUB_OUTPUT variable name mixup.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@keithwillcode keithwillcode self-assigned this Jan 9, 2024
Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 1:57pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 1:57pm
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2024 1:57pm
cal ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2024 1:57pm
cal-demo ⬜️ Ignored (Inspect) Jan 10, 2024 1:57pm
qa ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2024 1:57pm
ui ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2024 1:57pm

Copy link
Contributor

github-actions bot commented Jan 9, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link

deploysentinel bot commented Jan 9, 2024

Current Playwright Test Results Summary

✅ 13 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 01/10/2024 02:31:43pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 8751c81

Started: 01/10/2024 02:31:13pm UTC

⚠️ Flakes

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
11.24% (20) 20 / 178 runs
failed over last 7 days
85.96% (153) 153 / 178 runs
flaked over last 7 days

View Detailed Build Results


@@ -62,18 +62,18 @@ jobs:

- name: Get comment body
id: get-comment-body
if: success()
if: success() && github.event.number
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting this back as the last PR was merged with these removed but only for testing purposes.

@keithwillcode keithwillcode marked this pull request as ready for review January 9, 2024 15:00
@keithwillcode keithwillcode requested a review from a team January 9, 2024 15:01
@keithwillcode keithwillcode added the High priority Created by Linear-GitHub Sync label Jan 9, 2024
Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😓

@keithwillcode keithwillcode merged commit b69d885 into main Jan 10, 2024
37 of 38 checks passed
@keithwillcode keithwillcode deleted the fix/bundle-analysis branch January 10, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin core area: core, team members only devops High priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants