fix: add missing translations for workflows variables #13125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
CarinaWolli
commented
Jan 9, 2024
| @@ -2148,7 +2151,6 @@ | |||
| "overlay_my_calendar_toc":"By connecting to your calendar, you accept our privacy policy and terms of use. You may revoke access at any time.", | |||
| "view_overlay_calendar_events":"View your calendar events to prevent clashed booking.", | |||
| "join_event_location":"Join {{eventLocationType}}", | |||
| "join_meeting":"Join Meeting", | |||
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
Udit-takkar
reviewed
Jan 9, 2024
| @@ -1848,6 +1850,7 @@ | |||
| "verification_code": "Verification code", | |||
| "can_you_try_again": "Can you try again with a different time?", | |||
| "verify": "Verify", | |||
| "timezone_variable": "Timezone", | |||
There was a problem hiding this comment.
Thanks 👍. I thought these keys were not being used
Udit-takkar
approved these changes
Jan 9, 2024
Current Playwright Test Results Summary✅ 381 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 01/11/2024 03:11:16pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: ff5c129 Started: 01/11/2024 03:00:23pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking with Seats Multiple Attendees can book a seated event time slot
Retry 1 • Initial Attempt |
0% (0)0 / 234 runsfailed over last 7 days |
4.70% (11)11 / 234 runsflaked over last 7 days |
📄 apps/web/playwright/teams.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams - NonOrg Can create a private team
Retry 1 • Initial Attempt |
35.20% (88)88 / 250 runsfailed over last 7 days |
8.80% (22)22 / 250 runsflaked over last 7 days |
📄 apps/web/playwright/booking/longTextQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Number Question Long Text and Number required
Retry 1 • Initial Attempt |
0% (0)0 / 237 runsfailed over last 7 days |
3.38% (8)8 / 237 runsflaked over last 7 days |
📄 apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and multiselect Question Phone required and multiselect text not required
Retry 1 • Initial Attempt |
0% (0)0 / 241 runsfailed over last 7 days |
2.07% (5)5 / 241 runsflaked over last 7 days |
📄 apps/web/playwright/team/team-invitation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Team Invitation (verified)
Retry 1 • Initial Attempt |
0.40% (1)1 / 252 runfailed over last 7 days |
1.19% (3)3 / 252 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user -- future enabling recurring event comes with default options
Retry 1 • Initial Attempt |
1.17% (3)3 / 257 runsfailed over last 7 days |
4.67% (12)12 / 257 runsflaked over last 7 days |
|
Event Types tests user -- legacy Different Locations Tests can add Attendee Phone Number location and book with it
Retry 2 • Retry 1 • Initial Attempt |
0% (0)0 / 249 runsfailed over last 7 days |
2.01% (5)5 / 249 runsflaked over last 7 days |
📄 apps/web/playwright/signup.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Signup Flow Test Signup with valid (non premium) username
Retry 1 • Initial Attempt |
0% (0)0 / 252 runsfailed over last 7 days |
5.95% (15)15 / 252 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Router URL should work
Retry 1 • Initial Attempt |
0.40% (1)1 / 249 runfailed over last 7 days |
14.86% (37)37 / 249 runsflaked over last 7 days |
|
Routing Forms Seeded Routing Form Routing Link should validate fields
Retry 1 • Initial Attempt |
0% (0)0 / 249 runsfailed over last 7 days |
7.63% (19)19 / 249 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
12.45% (31)31 / 249 runsfailed over last 7 days |
85.14% (212)212 / 249 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
1.62% (4)4 / 247 runsfailed over last 7 days |
83.40% (206)206 / 247 runsflaked over last 7 days |
PeerRich
added
🐛 bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add missing translations:
Were removed here: a48e7cb#diff-57de4b8e5231f1d699891d98b0381d56e9e24537b0ca5420d1fba4f0597370bc