fix: Oauth refreshToken endpoint for teams #13159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
Current Playwright Test Results Summary✅ 381 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 01/11/2024 09:40:32pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: ec01f9e Started: 01/11/2024 09:29:13pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking with Seats User can create a seated event (2 seats as example)
Retry 1 • Initial Attempt |
0.80% (2)2 / 249 runsfailed over last 7 days |
10.84% (27)27 / 249 runsflaked over last 7 days |
📄 apps/web/playwright/booking/selectQuestion.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Select Question and Address Question Select and Address not required
Retry 1 • Initial Attempt |
0% (0)0 / 254 runsfailed over last 7 days |
3.15% (8)8 / 254 runsflaked over last 7 days |
|
Booking With Phone Question and Each Other Question Booking With Select Question and Radio group Question Select required and Radio group required
Retry 1 • Initial Attempt |
1.19% (3)3 / 253 runsfailed over last 7 days |
1.58% (4)4 / 253 runsflaked over last 7 days |
📄 apps/web/playwright/booking/radioGroupQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and multiselect Question Radio and multiselect text not required
Retry 1 • Initial Attempt |
0% (0)0 / 254 runsfailed over last 7 days |
3.54% (9)9 / 254 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 3 Flakes
Top 1 Common Error Messages
|
|
3 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user -- future can add new event type
Retry 1 • Initial Attempt |
0.73% (2)2 / 273 runsfailed over last 7 days |
0.73% (2)2 / 273 runsflaked over last 7 days |
|
Event Types tests user -- future enabling recurring event comes with default options
Retry 1 • Initial Attempt |
1.10% (3)3 / 273 runsfailed over last 7 days |
5.13% (14)14 / 273 runsflaked over last 7 days |
|
Event Types tests user -- legacy Different Locations Tests Can add Cal video location and book with it
Retry 1 • Initial Attempt |
0.38% (1)1 / 264 runfailed over last 7 days |
3.41% (9)9 / 264 runsflaked over last 7 days |
📄 apps/web/playwright/oauth-provider.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
OAuth Provider redirect not logged-in users to login page and after forward to authorization page
Retry 1 • Initial Attempt |
0% (0)0 / 264 runsfailed over last 7 days |
2.27% (6)6 / 264 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Router URL should work
Retry 1 • Initial Attempt |
0.38% (1)1 / 265 runfailed over last 7 days |
14.72% (39)39 / 265 runsflaked over last 7 days |
|
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1 • Initial Attempt |
0% (0)0 / 265 runsfailed over last 7 days |
11.70% (31)31 / 265 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 3 Flakes
Top 1 Common Error Messages
|
|
3 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt |
12.83% (34)34 / 265 runsfailed over last 7 days |
84.91% (225)225 / 265 runsflaked over last 7 days |
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 2 • Retry 1 • Initial Attempt |
2.26% (6)6 / 266 runsfailed over last 7 days |
55.26% (147)147 / 266 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
2.28% (6)6 / 263 runsfailed over last 7 days |
82.13% (216)216 / 263 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Preview Preview - embed-core should load
Retry 1 • Initial Attempt |
0% (0)0 / 264 runsfailed over last 7 days |
19.32% (51)51 / 264 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
1.89% (5)5 / 264 runsfailed over last 7 days |
35.23% (93)93 / 264 runsflaked over last 7 days |
keithwillcode
approved these changes
Jan 11, 2024
github-actions
bot
added
zapier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The Access token returned by
oauth/refreshTokenwasn't valid for teams. This fixes the issue that a Zap connected to a team account always needs to be reconnected when editing.