Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bundle analysis message #13161

Merged
merged 1 commit into from
Jan 11, 2024
Merged

fix: Bundle analysis message #13161

merged 1 commit into from
Jan 11, 2024

Conversation

keithwillcode
Copy link
Contributor

What does this PR do?

Attempting to fix an error we are now seeing where the body can't be found to write into the PR comment.

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  • After merge, ensure bundle analysis succeeds on PRs

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@keithwillcode keithwillcode added the High priority Created by Linear-GitHub Sync label Jan 11, 2024
@keithwillcode keithwillcode requested a review from a team January 11, 2024 01:52
@keithwillcode keithwillcode self-assigned this Jan 11, 2024
Copy link
Contributor

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 2:08am
api ❌ Failed (Inspect) Jan 11, 2024 2:08am
dev ❌ Failed (Inspect) Jan 11, 2024 2:08am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 11, 2024 2:08am
cal-demo ⬜️ Ignored (Inspect) Jan 11, 2024 2:08am
ui ⬜️ Ignored (Inspect) Jan 11, 2024 2:08am

Copy link

deploysentinel bot commented Jan 11, 2024

Current Playwright Test Results Summary

✅ 47 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 01/11/2024 02:24:56am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 7764cd9

Started: 01/11/2024 02:23:04am UTC

⚠️ Flakes

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
FORM_SUBMITTED on submitting team form, triggers team webhook
Retry 1Initial Attempt
3.59% (7) 7 / 195 runs
failed over last 7 days
16.41% (32) 32 / 195 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does look like an error.

@emrysal emrysal merged commit 5950c5a into main Jan 11, 2024
36 of 39 checks passed
@emrysal emrysal deleted the fix/bundle-analysis-comment branch January 11, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only devops High priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants