Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename 'reason' to 'cancellationReason' to match the api #13178

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

stylessh
Copy link
Contributor

What does this PR do?

Rename swagger definition param 'reason' to 'cancellationReason' matching the backend params.

Fixes #13165

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  • Check the swagger docs on booking deletion.
  • Ensure that is matching the params on the api endpoint.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Copy link

vercel bot commented Jan 11, 2024

@stylessh is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Jan 11, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added the community Created by Linear-GitHub Sync label Jan 11, 2024
@PeerRich PeerRich requested a review from a team January 11, 2024 22:56
@PeerRich PeerRich added Medium priority Created by Linear-GitHub Sync Low priority Created by Linear-GitHub Sync and removed Medium priority Created by Linear-GitHub Sync labels Jan 11, 2024
Copy link
Member

@alishaz-polymath alishaz-polymath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙌

@Udit-takkar Udit-takkar enabled auto-merge (squash) January 12, 2024 10:47
@Udit-takkar Udit-takkar merged commit 40d8f34 into calcom:main Jan 12, 2024
29 of 37 checks passed
@stylessh stylessh deleted the chore/booking-cancellation-reason branch January 12, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Created by Linear-GitHub Sync Low priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API - Incorrect documentation and parameter definition for Booking Cancel
5 participants