fix: add missing title #13307

anikdhabal · 2024-01-18T15:44:55Z

What does this PR do?

Fixes #13241
/claim #13241

vercel · 2024-01-18T15:45:01Z

@anikdhabal is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

github-actions · 2024-01-18T15:45:07Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions · 2024-01-18T15:55:07Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (`350 KB`)
`/settings/my-account/out-of-office`	`269.62 KB`	457.76 KB	130.79% (🟢 -1.76%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Udit-takkar · 2024-01-19T11:35:36Z

apps/web/components/apps/layouts/AppsLayout.tsx

@@ -22,7 +22,8 @@ export default function AppsLayout({ children, actions, emptyStore, ...rest }: A

  if (session.status === "loading") return <></>;
  return (
-    <ShellMain {...rest} actions={actions?.("block")} hideHeadingOnMobile>
+    <ShellMain {...rest} actions={actions?.("block")} withoutSeo hideHeadingOnMobile>
+      <HeadSeo title="App Store" description="Connecting people, technology and the workplace." />


I think we should use i18n here.

and other pages as well

I was not using i18n, as @PeerRich suggested using English here.

I don't understand why we are passing withoutSeo to ShellMain? Doesn't ShellMain support for SEO work correctly?

It seems counterintuitive to me.

yeah currently it is useless.

hariombalhara · 2024-01-20T03:48:13Z

apps/web/pages/bookings/[status].tsx

@@ -153,7 +153,8 @@ export default function Bookings() {
  const [animationParentRef] = useAutoAnimate<HTMLDivElement>();

  return (
-    <ShellMain hideHeadingOnMobile heading={t("bookings")} subtitle={t("bookings_description")}>
+    <ShellMain withoutSeo hideHeadingOnMobile heading={t("bookings")} subtitle={t("bookings_description")}>


It looks like ShellMain doesn't support adding HeadSeo at all(which seems like a bug that creeped in later). Shouldn't we simply support HeadSeo there and avoid import HeadSeo everywhere ShellMain is already used

It's pretty cool idea to support HeadSeo there and avoid import it everywhere.

hariombalhara

Thanks @anikdhabal 🙏 Left some comments.

anikdhabal · 2024-01-20T05:37:19Z

Thanks @anikdhabal 🙏 Left some comments.

Thanks for your review. Let me fix that quickly.

Udit-takkar

The title keeps changing back to Cal.com | Cal.com on other pages

Screen.Recording.2024-01-23.at.4.39.03.PM.mov

anikdhabal · 2024-01-23T18:12:31Z

The title keeps changing back to Cal.com | Cal.com on other pages

Screen.Recording.2024-01-23.at.4.39.03.PM.mov

Thanks for the review. I've updated the code, and now everything is working fine.

vercel · 2024-02-05T20:22:24Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 5, 2024 8:40pm

keithwillcode · 2024-02-05T20:39:07Z

Looks like this one consistently fails tests

anikdhabal · 2024-02-05T20:41:50Z

Looks like this one consistently fails tests

So what am I going to do now? Also, those tests are not related to the changes.

keithwillcode · 2024-02-06T13:15:15Z

@anikdhabal No, no worries. We'll look into getting the tests fixed.

anikdhabal · 2024-02-06T13:18:32Z

@anikdhabal No, no worries. We'll look into getting the tests fixed.

Thank you.

Udit-takkar · 2024-02-06T18:24:48Z

this test "login flow user & logout using dashboard" is only failing in this PR. I see two sidebar when i run this E2E test locally on this branch.

anikdhabal · 2024-02-06T23:56:38Z

this test "login flow user & logout using dashboard" is only failing in this PR. I see two sidebar when i run this E2E test locally on this branch.

Thanks for the review. I am on it.

anikdhabal · 2024-02-07T18:53:18Z

Hey @Udit-takkar @keithwillcode two Layout is visible in future version.

anikdhabal · 2024-02-07T19:41:21Z

The reason for having two layouts in future mode is that we wrap the component with getLayout. Therefore, we either have to ensure that all components in future mode are wrapped with shellmain, or we have to make getLayout null there. So that we can use shell as a parent.

I will update the code by today and ensure that everything is perfect in both the default and future modes.

anikdhabal · 2024-02-07T20:31:55Z

I've fixed the double layout issue.

anikdhabal · 2024-02-07T20:50:29Z

@keithwillcode finally. Thanks for your review.

add missing title

037e96a

github-actions bot added Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work 💎 Bounty A bounty on Algora.io labels Jan 18, 2024

github-actions bot added 🙋🏻‍♂️help wanted Help from the community is appreciated 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Jan 18, 2024

algora-pbc bot mentioned this pull request Jan 18, 2024

[CAL-2974] Missing <title> on a bunch of pages. #13241

Closed

7 tasks

algora-pbc bot added the 🙋 Bounty claim label Jan 18, 2024

add

95ce1d2

keithwillcode added the community Created by Linear-GitHub Sync label Jan 18, 2024

keithwillcode requested a review from PeerRich January 18, 2024 19:04

keithwillcode added the ui area: UI, frontend, button, form, input label Jan 18, 2024

update

9159993

PeerRich requested a review from Udit-takkar January 18, 2024 23:02

Udit-takkar reviewed Jan 19, 2024

View reviewed changes

hariombalhara reviewed Jan 20, 2024

View reviewed changes

hariombalhara previously requested changes Jan 20, 2024

View reviewed changes

keithwillcode added this to the v3.8 milestone Jan 20, 2024

update

7d21119

github-actions bot added the linear Sync Github Issue from community members to Linear.app label Jan 21, 2024

Udit-takkar reviewed Jan 23, 2024

View reviewed changes

update

bbab233

anikdhabal and others added 3 commits January 24, 2024 00:04

Merge branch 'main' into issue#13241

cf00403

Merge branch 'main' into issue#13241

0be3cf2

fix lint

7d47c40

keithwillcode enabled auto-merge (squash) February 5, 2024 18:17

keithwillcode added 2 commits February 5, 2024 17:18

Merge branch 'main' into issue#13241

3beeabc

Merge branch 'main' into issue#13241

3bc6191

vercel bot deployed to Preview – dev February 5, 2024 20:34 View deployment

vercel bot deployed to Preview – api February 5, 2024 20:40 View deployment

anikdhabal and others added 2 commits February 6, 2024 02:13

Merge branch 'main' into issue#13241

9d417e2

Merge branch 'main' into issue#13241

9e58c52

Udit-takkar and others added 2 commits February 6, 2024 21:09

Merge branch 'main' into issue#13241

e33209c

Merge branch 'main' into issue#13241

b7f1ef4

keithwillcode marked this pull request as draft February 7, 2024 00:00

auto-merge was automatically disabled February 7, 2024 00:00
Pull request was converted to draft

Merge branch 'main' into issue#13241

4fe7ed8

anikdhabal and others added 2 commits February 7, 2024 20:24

update

3604fb0

Merge branch 'main' into issue#13241

3ce672c

vercel bot deployed to Preview – api February 7, 2024 20:48 View deployment

keithwillcode marked this pull request as ready for review February 7, 2024 20:49

keithwillcode approved these changes Feb 7, 2024

View reviewed changes

keithwillcode merged commit 97dcb2a into calcom:main Feb 7, 2024
30 of 37 checks passed

vercel bot deployed to Preview – dev February 7, 2024 20:54 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: add missing title #13307

fix: add missing title #13307

anikdhabal commented Jan 18, 2024 •

edited

Loading

vercel bot commented Jan 18, 2024

github-actions bot commented Jan 18, 2024 •

edited

Loading

github-actions bot commented Jan 18, 2024 •

edited

Loading

Udit-takkar Jan 19, 2024

Udit-takkar Jan 19, 2024

anikdhabal Jan 19, 2024 •

edited

Loading

Udit-takkar Jan 19, 2024

hariombalhara Jan 20, 2024 •

edited

Loading

anikdhabal Jan 21, 2024 •

edited

Loading

hariombalhara Jan 20, 2024

anikdhabal Jan 20, 2024

hariombalhara left a comment

anikdhabal commented Jan 20, 2024

Udit-takkar left a comment

anikdhabal commented Jan 23, 2024 •

edited

Loading

vercel bot commented Feb 5, 2024 •

edited

Loading

keithwillcode commented Feb 5, 2024

anikdhabal commented Feb 5, 2024

keithwillcode commented Feb 6, 2024

anikdhabal commented Feb 6, 2024

Udit-takkar commented Feb 6, 2024

anikdhabal commented Feb 6, 2024

anikdhabal commented Feb 7, 2024 •

edited

Loading

anikdhabal commented Feb 7, 2024 •

edited

Loading

anikdhabal commented Feb 7, 2024

anikdhabal commented Feb 7, 2024 •

edited

Loading

fix: add missing title #13307

fix: add missing title #13307

Conversation

anikdhabal commented Jan 18, 2024 • edited Loading

What does this PR do?

vercel bot commented Jan 18, 2024

github-actions bot commented Jan 18, 2024 • edited Loading

github-actions bot commented Jan 18, 2024 • edited Loading

📦 Next.js Bundle Analysis for @calcom/web

One Page Changed Size

Udit-takkar Jan 19, 2024

Choose a reason for hiding this comment

Udit-takkar Jan 19, 2024

Choose a reason for hiding this comment

anikdhabal Jan 19, 2024 • edited Loading

Choose a reason for hiding this comment

Udit-takkar Jan 19, 2024

Choose a reason for hiding this comment

hariombalhara Jan 20, 2024 • edited Loading

Choose a reason for hiding this comment

anikdhabal Jan 21, 2024 • edited Loading

Choose a reason for hiding this comment

hariombalhara Jan 20, 2024

Choose a reason for hiding this comment

anikdhabal Jan 20, 2024

Choose a reason for hiding this comment

hariombalhara left a comment

Choose a reason for hiding this comment

anikdhabal commented Jan 20, 2024

Udit-takkar left a comment

Choose a reason for hiding this comment

anikdhabal commented Jan 23, 2024 • edited Loading

vercel bot commented Feb 5, 2024 • edited Loading

keithwillcode commented Feb 5, 2024

anikdhabal commented Feb 5, 2024

keithwillcode commented Feb 6, 2024

anikdhabal commented Feb 6, 2024

Udit-takkar commented Feb 6, 2024

anikdhabal commented Feb 6, 2024

anikdhabal commented Feb 7, 2024 • edited Loading

anikdhabal commented Feb 7, 2024 • edited Loading

anikdhabal commented Feb 7, 2024

anikdhabal commented Feb 7, 2024 • edited Loading

anikdhabal commented Jan 18, 2024 •

edited

Loading

github-actions bot commented Jan 18, 2024 •

edited

Loading

github-actions bot commented Jan 18, 2024 •

edited

Loading

anikdhabal Jan 19, 2024 •

edited

Loading

hariombalhara Jan 20, 2024 •

edited

Loading

anikdhabal Jan 21, 2024 •

edited

Loading

anikdhabal commented Jan 23, 2024 •

edited

Loading

vercel bot commented Feb 5, 2024 •

edited

Loading

anikdhabal commented Feb 7, 2024 •

edited

Loading

anikdhabal commented Feb 7, 2024 •

edited

Loading

anikdhabal commented Feb 7, 2024 •

edited

Loading