fix: usage of CAL_URL #13326
Merged
fix: usage of CAL_URL #13326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
alishaz-polymath
approved these changes
Jan 19, 2024
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 442 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 02/07/2024 05:21:20pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 593f23a Started: 02/07/2024 05:11:16pm UTC
|
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and Address Question Multiple Email and Address not required
Retry 1 • Initial Attempt |
2.14% (7)7 / 327 runsfailed over last 7 days |
3.98% (13)13 / 327 runsflaked over last 7 days |
|
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and Radio group Question Booking With Multiple Email Question and Short text question Multiple Email required and Short text required
Retry 1 • Initial Attempt |
0.32% (1)1 / 315 runfailed over last 7 days |
4.76% (15)15 / 315 runsflaked over last 7 days |
📄 apps/web/playwright/booking/longTextQuestion.e2e.ts • 3 Flakes
Top 1 Common Error Messages
|
|
3 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and checkbox Question Long Text required and checkbox not required
Retry 1 • Initial Attempt |
0% (0)0 / 311 runsfailed over last 7 days |
3.54% (11)11 / 311 runsflaked over last 7 days |
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and multiselect Question Long Text and multiselect text required
Retry 1 • Initial Attempt |
0.65% (2)2 / 310 runsfailed over last 7 days |
5.81% (18)18 / 310 runsflaked over last 7 days |
|
Booking With Long Text Question and Each Other Question Long Text required and Number not required
Retry 1 • Initial Attempt |
0.32% (1)1 / 310 runfailed over last 7 days |
5.81% (18)18 / 310 runsflaked over last 7 days |
📄 apps/web/playwright/booking/responsiveBooking.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking page with no questions Booking page with 640x480 resolution
Retry 1 • Initial Attempt |
0% (0)0 / 300 runsfailed over last 7 days |
4.67% (14)14 / 300 runsflaked over last 7 days |
📄 apps/web/playwright/booking/selectQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Select Question and checkbox group Question Select required and checkbox group required
Retry 1 • Initial Attempt |
0% (0)0 / 299 runsfailed over last 7 days |
3.68% (11)11 / 299 runsflaked over last 7 days |
📄 apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Number Question Checkbox Group and Number not required
Retry 2 • Retry 1 • Initial Attempt |
0.95% (3)3 / 317 runsfailed over last 7 days |
5.36% (17)17 / 317 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1 • Initial Attempt |
5.11% (16)16 / 313 runsfailed over last 7 days |
37.38% (117)117 / 313 runsflaked over last 7 days |
📄 apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Address Question and Each Other Question Booking With Address Question and multiselect Question Address and multiselect text not required
Retry 1 • Initial Attempt |
0% (0)0 / 329 runsfailed over last 7 days |
4.86% (16)16 / 329 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Cannot update a users email when existing user has same email (verification enabled)
Retry 1 • Initial Attempt |
0% (0)0 / 16 runsfailed over last 7 days |
56.25% (9)9 / 16 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Organization Email not matching orgAutoAcceptEmail Team invitation
Retry 1 • Initial Attempt |
14.33% (47)47 / 328 runsfailed over last 7 days |
12.80% (42)42 / 328 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- future user Different Locations Tests Can add Cal video location and book with it
Retry 1 • Initial Attempt |
2.29% (8)8 / 350 runsfailed over last 7 days |
3.71% (13)13 / 350 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Preview Preview - embed-core should load
Retry 1 • Initial Attempt |
0% (0)0 / 333 runsfailed over last 7 days |
30.03% (100)100 / 333 runsflaked over last 7 days |
📄 apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Phone and Address required
Retry 1 • Initial Attempt |
0.90% (3)3 / 332 runsfailed over last 7 days |
4.22% (14)14 / 332 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
0.60% (2)2 / 331 runsfailed over last 7 days |
41.09% (136)136 / 331 runsflaked over last 7 days |
PeerRich
previously approved these changes
Jan 19, 2024
alishaz-polymath
previously requested changes
Jan 19, 2024
|
Converted back to draft while until decision is made |
keithwillcode
requested changes
Jan 29, 2024
Udit-takkar
changed the title
keithwillcode
previously approved these changes
Jan 29, 2024
keithwillcode
dismissed
alishaz-polymath’s stale review
Was decided to revert this
|
@keithwillcode we should wait for @zomars or @hariombalhara approval before merging |
|
I still don't think we should revert this. Also, if we need to revert this, it should just be the changes you made in the PR #12973. Right now it seem to be doing a complete replacement of CAL_URL. Also, CAL_URL handles the case of our previews, where website isn't setup and then we use WEBAPP_URL only. We need to consider that in any new approach that we use. Are there any more reports of broken links except the one case reported on threads? I have an expectation that WEBSITE_URL is set same as WEBAPP_URL by default(as set in .env.example), unless someone changes it, so WEBSITE_URL is always set and CAL_URL is same as WEBSITE_URL with some special handling |
|
@hariombalhara @Udit-takkar @zomars What do we need to do to move forward on this one? |
|
@zomars So merging this as is addresses @hariombalhara concerns? |
|
Seems like we have regression of this fix #10172 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes reverts this PR #12973
https://threads.com/thread/34561538856/34561538859?s=dUJjVzSUcZCeQtprQ7CdUc
Type of change