-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate formbricks for team disband action #13362
feat: integrate formbricks for team disband action #13362
Conversation
@ShubhamPalriwala is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Sixty-five Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
FORMBRICKS_HOST_URL=https://app.formbricks.com | ||
FORMBRICKS_ENVIRONMENT_ID= | ||
NEXT_PUBLIC_FORMBRICKS_HOST_URL=https://app.formbricks.com | ||
NEXT_PUBLIC_FORMBRICKS_ENVIRONMENT_ID= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShubhamPalriwala where can i get the environment ID to test this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DMed you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Udit-takkar @PeerRich Just double-checking that this is ok to be exposed client-side?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keithwillcode I don't think so there is any issue as we using initFormbricks inside useEffect we would have to use NEXT_PUBLIC_* to expose variable to client side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShubhamPalriwala After i changed my environement id variable I got this error.
![Screenshot 2024-01-23 at 6 32 38 PM](https://private-user-images.githubusercontent.com/53316345/298956975-e3ccb7bf-19cb-4ea7-92dd-0ac8ca73e5dd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk5NTEyNzQsIm5iZiI6MTcxOTk1MDk3NCwicGF0aCI6Ii81MzMxNjM0NS8yOTg5NTY5NzUtZTNjY2I3YmYtMTljYi00ZWE3LTkyZGQtMGFjOGNhNzNlNWRkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzAyVDIwMDkzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBjNDhjMTRjZWViNzliMzZiNTAwNWU1NTgwNGRlNDcyNzRlNTY5MjhiZTlhYzMxYTM5NTkwNDk4YTFmZjM0MzImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Y5g140UfKWAU_ujOzb-S0ohA8V1qrC-Dd1HlsJPZ8-I)
Hey @Udit-takkar, that's unexpected! But I do see that a request already went through for the same! Could you try disbanding the team and see if the action as well as a survey gets triggered? |
@Udit-takkar This looks like a caching issue on our side that we will try to reproduce and solve 😊. |
Hey there, there is a merge conflict, can you take a look? |
@Udit-takkar What are the next steps for the review? Is everything else working as expected? 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShubhamPalriwala works fine 👍. there are some conflicts that needs to be resolved.
we would have to rename environment variables on vercel cc: @keithwillcode
0e6ac3f
to
e4d355a
Compare
Hey team, I've resolved the conflicts! Please let us know of the next steps 🤞🏼 |
Before merge, we need to make sure the yarn.lock changes are correct. It's a lot. |
Hey @keithwillcode, A main merge and a fresh slate fixed the Should be relatively easier for you as compared to before 😎 |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@keithwillcode Happy to see this got merged 🤩 |
What does this PR do?
Shows Formbricks In-App Survey whenever a user disbands ie Deletes a team!
team_disbanded
action whenever the deleteTeam happens in the UI. The moment this happens, the user will be displayed the in-app survey that you've configured!This PR is an updated version of #10659
Requirement/Documentation
team_disbanded
on app.formbricks.comType of change
How should this be tested?
Mandatory Tasks