feat: let org admins change usernames #13384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
github-actions
bot
added
Medium priority
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 447 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 02/22/2024 07:47:05am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: cecbfe6 Started: 02/22/2024 07:38:15am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Change username on settings User can change username
Retry 1 • Initial Attempt |
1.46% (3)3 / 206 runsfailed over last 7 days |
3.40% (7)7 / 206 runsflaked over last 7 days |
📄 apps/web/playwright/booking/longTextQuestion.e2e.ts • 4 Flakes
Top 1 Common Error Messages
|
|
4 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Checkbox Group Question Long Text and Checkbox Group required
Retry 1 • Initial Attempt |
0% (0)0 / 210 runsfailed over last 7 days |
2.86% (6)6 / 210 runsflaked over last 7 days |
|
Booking With Long Text Question and Each Other Question Long Text required and Number not required
Retry 1 • Initial Attempt |
0.48% (1)1 / 210 runfailed over last 7 days |
5.24% (11)11 / 210 runsflaked over last 7 days |
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Phone Question Long Text required and Phone not required
Retry 1 • Initial Attempt |
0% (0)0 / 209 runsfailed over last 7 days |
5.26% (11)11 / 209 runsflaked over last 7 days |
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and select Question Long Text and select required
Retry 1 • Initial Attempt |
0% (0)0 / 208 runsfailed over last 7 days |
6.73% (14)14 / 208 runsflaked over last 7 days |
📄 apps/web/playwright/booking/selectQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Select Question and Radio group Question Select required and Radio group required
Retry 1 • Initial Attempt |
0% (0)0 / 222 runsfailed over last 7 days |
4.50% (10)10 / 222 runsflaked over last 7 days |
📄 apps/web/playwright/booking/responsiveBooking.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking page with no questions Booking page with 1920x1080 resolution
Retry 1 • Initial Attempt |
0% (0)0 / 225 runsfailed over last 7 days |
8% (18)18 / 225 runsflaked over last 7 days |
|
Booking page with no questions Booking page with 1280x720 resolution
Retry 1 • Initial Attempt |
0% (0)0 / 225 runsfailed over last 7 days |
8.44% (19)19 / 225 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1 • Initial Attempt |
0.47% (1)1 / 215 runfailed over last 7 days |
43.26% (93)93 / 215 runsflaked over last 7 days |
|
Login and logout tests -- future Login flow validations -- legacy Should warn when user does not exist
Retry 1 • Initial Attempt |
0% (0)0 / 215 runsfailed over last 7 days |
1.40% (3)3 / 215 runsflaked over last 7 days |
📄 apps/web/playwright/booking/radioGroupQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and multiselect Question Radio and multiselect text not required
Retry 1 • Initial Attempt |
0% (0)0 / 227 runsfailed over last 7 days |
5.73% (13)13 / 227 runsflaked over last 7 days |
📄 apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and select Question Phone required and select not required
Retry 1 • Initial Attempt |
0% (0)0 / 229 runsfailed over last 7 days |
4.80% (11)11 / 229 runsflaked over last 7 days |
📄 apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Address Question and Each Other Question Booking With Address Question and Long text Question Address and Long Text not required
Retry 1 • Initial Attempt |
0% (0)0 / 220 runsfailed over last 7 days |
6.82% (15)15 / 220 runsflaked over last 7 days |
|
Booking With Address Question and Each Other Question Booking With Address Question and Multi email Question Address and Multi email not required
Retry 1 • Initial Attempt |
0% (0)0 / 220 runsfailed over last 7 days |
5.45% (12)12 / 220 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Pending payment booking should not be confirmed by default
Retry 2 • Retry 1 • Initial Attempt |
1.36% (3)3 / 220 runsfailed over last 7 days |
20.45% (45)45 / 220 runsflaked over last 7 days |
📄 apps/web/playwright/reschedule.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Reschedule Tests Unpaid rescheduling should go to payment page
Retry 1 • Initial Attempt |
0.87% (2)2 / 230 runsfailed over last 7 days |
0.87% (2)2 / 230 runsflaked over last 7 days |
|
Reschedule Tests Paid rescheduling should go to success page
Retry 1 • Initial Attempt |
0.87% (2)2 / 230 runsfailed over last 7 days |
0.43% (1)1 / 230 runflaked over last 7 days |
keithwillcode
previously requested changes
Jan 24, 2024
likely more failing, havent tested locally at all yet 🙏 |
should fix the type checks now |
Udit-takkar
reviewed
Jan 29, 2024
|
Fixed:- Username Updation Screen.Recording.2024-02-17.at.1.21.35.PM.mov |
sean-brydon
previously requested changes
Feb 19, 2024
Okay let me try to replicate this bug. |
|
@sean-brydon Works fine for me. There is user with 'pro' username in the DB but not in the org Screen.Recording.2024-02-19.at.4.09.17.PM.mov |
joeauyeung
approved these changes
Feb 19, 2024
| const hasUsernameUpdated = input.username !== requestedMember.user.username; | ||
|
|
||
| if (input.username && hasUsernameUpdated && user.profile.organization?.slug) { | ||
| const checkRegularUsernameRes = await checkRegularUsername( |
There was a problem hiding this comment.
NIT: I noticed that checkRegularUsername is used only within an org context. Should we rename this function so it's more obvious when reading the function name? @hariombalhara thoughts?
PeerRich
deleted the
13383-cal-3010-org-admins-should-be-able-to-change-usernames
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
havent tested but could work, unless the API needs more permission to change username, not sure