Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filtering events bug in bookings page #13447

Merged
merged 7 commits into from
Feb 7, 2024
Merged

fix: filtering events bug in bookings page #13447

merged 7 commits into from
Feb 7, 2024

Conversation

SomayChauhan
Copy link
Member

@vercel Vercel
Copy link

vercel bot commented Jan 29, 2024

@SomayChauhan is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 29, 2024 •
edited
Loading

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added event types Created by Linear-GitHub Sync Medium priority Created by Linear-GitHub Sync 🐛 bug Something isn't working labels Jan 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 29, 2024 •
edited
Loading

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@keithwillcode keithwillcode added this to the v3.9 milestone Jan 29, 2024
@keithwillcode keithwillcode added the community Created by Linear-GitHub Sync label Jan 29, 2024
@PeerRich PeerRich modified the milestones: v3.9, v3.8 Feb 5, 2024
joeauyeung
joeauyeung requested changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@joeauyeung joeauyeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When event types are created, the user creating the event type is added under users. When team members are added as hosts. I think we should be filtering if the user being filtered is under the users OR hosts column.

joeauyeung
joeauyeung approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@joeauyeung joeauyeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected. Thanks for the quick turnaround @SomayChauhan!

@Udit-takkar Udit-takkar enabled auto-merge (squash) February 7, 2024 09:38
@Udit-takkar Udit-takkar merged commit e377997 into calcom:main Feb 7, 2024
29 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Udit-takkar Udit-takkar Udit-takkar approved these changes

@joeauyeung joeauyeung joeauyeung approved these changes

Assignees
No one assigned
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync event types Created by Linear-GitHub Sync Medium priority Created by Linear-GitHub Sync
Projects
None yet
Milestone
v3.8
Development

Successfully merging this pull request may close these issues.

[CAL-3038] Filtering events not working properly
5 participants
@SomayChauhan @Udit-takkar @joeauyeung @keithwillcode @PeerRich