perf: Don't process date overrides outside of requested boundaries #13495
+84
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
github-actions
bot
added
bookings
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 440 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 02/07/2024 03:20:06am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: e291492 Started: 02/07/2024 03:12:20am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
pro user -- legacy Time slots should be reserved when selected
Retry 1 • Initial Attempt |
0% (0)0 / 236 runsfailed over last 7 days |
4.66% (11)11 / 236 runsflaked over last 7 days |
📄 apps/web/playwright/booking/longTextQuestion.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and checkbox Question Long Text and checkbox required
Retry 1 • Initial Attempt |
0% (0)0 / 275 runsfailed over last 7 days |
5.82% (16)16 / 275 runsflaked over last 7 days |
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and select Question Long Text required and select not required
Retry 2 • Retry 1 • Initial Attempt |
1.11% (3)3 / 270 runsfailed over last 7 days |
5.19% (14)14 / 270 runsflaked over last 7 days |
📄 apps/web/playwright/booking/selectQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Select Question and Number Question Select and Number not required
Retry 1 • Initial Attempt |
0% (0)0 / 256 runsfailed over last 7 days |
4.69% (12)12 / 256 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Login and logout tests -- future Login flow validations -- legacy Should warn when user does not exist
Retry 1 • Initial Attempt |
0.36% (1)1 / 276 runfailed over last 7 days |
2.90% (8)8 / 276 runsflaked over last 7 days |
📄 apps/web/playwright/booking/responsiveBooking.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking page with no questions Booking page with 1280x720 resolution
Retry 1 • Initial Attempt |
0.76% (2)2 / 262 runsfailed over last 7 days |
3.44% (9)9 / 262 runsflaked over last 7 days |
📄 apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and multiselect Question Checkbox Group and multiselect text not required
Retry 1 • Initial Attempt |
0.35% (1)1 / 283 runfailed over last 7 days |
4.59% (13)13 / 283 runsflaked over last 7 days |
📄 apps/web/playwright/booking/radioGroupQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and Number Question Radio and Number not required
Retry 1 • Initial Attempt |
0.73% (2)2 / 273 runsfailed over last 7 days |
6.23% (17)17 / 273 runsflaked over last 7 days |
📄 apps/web/playwright/booking/allQuestions.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With All Questions Selecting and filling all questions as required
Retry 1 • Initial Attempt |
0.69% (2)2 / 288 runsfailed over last 7 days |
3.82% (11)11 / 288 runsflaked over last 7 days |
📄 apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 3 Flakes
Top 1 Common Error Messages
|
|
3 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Address Question and Each Other Question Booking With Address Question and Checkbox Question Address required and checkbox required
Retry 1 • Initial Attempt |
2.32% (7)7 / 302 runsfailed over last 7 days |
5.30% (16)16 / 302 runsflaked over last 7 days |
|
Booking With Address Question and Each Other Question Booking With Address Question and Multi email Question Address and Multi email not required
Retry 1 • Initial Attempt |
0% (0)0 / 292 runsfailed over last 7 days |
7.19% (21)21 / 292 runsflaked over last 7 days |
|
Booking With Address Question and Each Other Question Booking With Address Question and Radio group Question Address and Radio group not required
Retry 1 • Initial Attempt |
0% (0)0 / 289 runsfailed over last 7 days |
4.15% (12)12 / 289 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- future user Different Locations Tests can add Attendee Phone Number location and book with it
Retry 1 • Initial Attempt |
1.97% (6)6 / 305 runsfailed over last 7 days |
7.87% (24)24 / 305 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes
Top 1 Common Error Messages
|
|
8 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
-3.46% (-10)-10 / 289 runsfailed over last 7 days |
53.29% (154)154 / 289 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-106.94% (-154)-154 / 144 runsfailed over last 7 days |
106.94% (154)154 / 144 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-99.29% (-140)-140 / 141 runsfailed over last 7 days |
99.29% (140)140 / 141 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-93.79% (-136)-136 / 145 runsfailed over last 7 days |
96.55% (140)140 / 145 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-99.29% (-140)-140 / 141 runsfailed over last 7 days |
99.29% (140)140 / 141 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-99.29% (-140)-140 / 141 runsfailed over last 7 days |
99.29% (140)140 / 141 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-99.29% (-140)-140 / 141 runsfailed over last 7 days |
99.29% (140)140 / 141 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-99.29% (-140)-140 / 141 runsfailed over last 7 days |
99.29% (140)140 / 141 runsflaked over last 7 days |
sean-brydon
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #13358.
Date overrides on user's availability settings were being added to the list of slots and their calculations even when the overrides fell outside of the start/end window of the requested schedule.
Type of change
How should this be tested?
Mandatory Tasks