Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Flakiness in location tests #13557

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Conversation

Udit-takkar
Copy link
Contributor

What does this PR do?

Fixes # (issue) Test failure messages similar to this

Screenshot 2024-02-06 at 6 05 04 PM

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Copy link

vercel bot commented Feb 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2024 2:43pm
cal-demo 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 6, 2024 2:43pm
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2024 2:43pm
cal ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2024 2:43pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2024 2:43pm
qa ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2024 2:43pm
ui ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2024 2:43pm

Copy link
Contributor

github-actions bot commented Feb 6, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link
Contributor

github-actions bot commented Feb 6, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Feb 6, 2024

Current Playwright Test Results Summary

✅ 440 Passing - ⚠️ 19 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 02/06/2024 02:52:15pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 0bdc380

Started: 02/06/2024 02:41:23pm UTC

⚠️ Flakes

📄   apps/web/playwright/booking/multipleEmailQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and Address Question Multiple Email required and Address required
Retry 1Initial Attempt
4.14% (12) 12 / 290 runs
failed over last 7 days
5.52% (16) 16 / 290 runs
flaked over last 7 days

📄   apps/web/playwright/booking/longTextQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Long Text Question and Each Other Question Booking With Long Text Question and checkbox Question Long Text and checkbox required
Retry 1Initial Attempt
0% (0) 0 / 265 runs
failed over last 7 days
5.66% (15) 15 / 265 runs
flaked over last 7 days

📄   apps/web/playwright/booking/collectiveEventType/collectiveEventType.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Collective event type Book a Collective event type (with added guest)
Retry 1Initial Attempt
0% (0) 0 / 261 runs
failed over last 7 days
2.68% (7) 7 / 261 runs
flaked over last 7 days

📄   apps/web/playwright/booking/responsiveBooking.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking page with no questions Booking page with 640x480 resolution
Retry 1Initial Attempt
0% (0) 0 / 254 runs
failed over last 7 days
5.51% (14) 14 / 254 runs
flaked over last 7 days

📄   apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Address Question and Each Other Question Booking With Address Question and Multi email Question Address and Multi email not required
Retry 1Initial Attempt
0% (0) 0 / 282 runs
failed over last 7 days
6.74% (19) 19 / 282 runs
flaked over last 7 days
Booking With Address Question and Each Other Question Booking With Address Question and Radio group Question Address and Radio group not required
Retry 1Initial Attempt
0% (0) 0 / 278 runs
failed over last 7 days
5.04% (14) 14 / 278 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- legacy user Different Locations Tests Can add Organzer Phone Number location and book with it
Retry 1Initial Attempt
0% (0) 0 / 295 runs
failed over last 7 days
2.71% (8) 8 / 295 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization Email not matching orgAutoAcceptEmail Team invitation
Retry 1Initial Attempt
15.71% (44) 44 / 280 runs
failed over last 7 days
14.29% (40) 40 / 280 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes

Top 1 Common Error Messages

null

8 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
-3.53% (-10) -10 / 283 runs
failed over last 7 days
48.06% (136) 136 / 283 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
-87.18% (-136) -136 / 156 runs
failed over last 7 days
87.18% (136) 136 / 156 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
-75.64% (-118) -118 / 156 runs
failed over last 7 days
78.21% (122) 122 / 156 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
-80.26% (-122) -122 / 152 runs
failed over last 7 days
80.26% (122) 122 / 152 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1Initial Attempt
-80.26% (-122) -122 / 152 runs
failed over last 7 days
80.26% (122) 122 / 152 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-80.26% (-122) -122 / 152 runs
failed over last 7 days
80.26% (122) 122 / 152 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-80.26% (-122) -122 / 152 runs
failed over last 7 days
80.26% (122) 122 / 152 runs
flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1Initial Attempt
-80.26% (-122) -122 / 152 runs
failed over last 7 days
80.26% (122) 122 / 152 runs
flaked over last 7 days

📄   apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and select Question Phone and select required
Retry 1Initial Attempt
0.37% (1) 1 / 272 run
failed over last 7 days
5.88% (16) 16 / 272 runs
flaked over last 7 days

📄   apps/web/playwright/reschedule.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Reschedule Tests Unpaid rescheduling should go to payment page
Retry 1Initial Attempt
2.40% (7) 7 / 292 runs
failed over last 7 days
1.03% (3) 3 / 292 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1Initial Attempt
0.36% (1) 1 / 281 run
failed over last 7 days
38.43% (108) 108 / 281 runs
flaked over last 7 days

View Detailed Build Results


@keithwillcode keithwillcode requested a review from a team February 6, 2024 13:35
@keithwillcode keithwillcode added the Urgent Created by Linear-GitHub Sync label Feb 6, 2024
@keithwillcode keithwillcode added this to the v3.8 milestone Feb 6, 2024
@keithwillcode keithwillcode merged commit a551383 into main Feb 6, 2024
38 checks passed
@keithwillcode keithwillcode deleted the fix/location-tests-flakiness branch February 6, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only Urgent Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants