-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 2FA OTP flaky test #13583
fix: 2FA OTP flaky test #13583
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
await removeOtpInput(page); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing last digit to prevent auto submitting of form while we fill the correct OTP in the next line
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 2 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 02/07/2024 07:01:39pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 441ff32 Started: 02/07/2024 07:00:36pm UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Preview Preview - embed-core should load
Retry 1 • Initial Attempt |
0% (0)0 / 340 runsfailed over last 7 days |
30.59% (104)104 / 340 runsflaked over last 7 days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this PR do?
Fixes # (issue)
Reason why this test failed:-
We auto submit 2FA code when all the input elements are filled. In the E2E we first test wrong input and check for error message but when we fill in the correct six digit code every time we fill the code in input the form gets auto submitted because of
so an edge case like in the screenshot while we are filling in the code the last digit is same of both the correct code and incorrect code the form will successfully get submitted and line page.fill
locator('input[name="2fa6"]') failed
Requirement/Documentation
Type of change