refactor: trpc get schedule handler #13586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
keithwillcode
added
core
ThyMinimalDev
previously approved these changes
Feb 7, 2024
Current Playwright Test Results Summary✅ 69 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 02/07/2024 03:45:43pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 5d01d1d Started: 02/07/2024 03:43:10pm UTC
|
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Can update a users email (verification enabled)
Retry 1 • Initial Attempt |
33.33% (7)7 / 21 runsfailed over last 7 days |
38.10% (8)8 / 21 runsflaked over last 7 days |
|
Update Profile Cannot update a users email when existing user has same email (verification enabled)
Retry 1 • Initial Attempt |
0% (0)0 / 11 runsfailed over last 7 days |
45.45% (5)5 / 11 runsflaked over last 7 days |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In packages/trpc/server/routers/viewer/availability/schedule/get.handler.ts extract the logic that transforms schedule to return workingHours, availability and dateOverrides to the client into separate functions in packages/lib/schedules/client/transformers.ts.
Then re-use these functions. It is done because platform team needs functions from packages/lib/schedules/client/transformers.ts in order to transform schedule returned to the Availability atom.